VS OE: return all well-known project metadata in a well-defined object#3679
Merged
VS OE: return all well-known project metadata in a well-defined object#3679
Conversation
sbanni
approved these changes
Sep 21, 2020
zivkan
approved these changes
Sep 21, 2020
| && framework.IsSpecificFramework) | ||
| if (framework.IsSpecificFramework) | ||
| { | ||
| frameworks.Add(framework.DotNetFrameworkName); |
Member
There was a problem hiding this comment.
Out of scope for this PR, but use of NuGetFramework.DotNetFameworkName can have unexpected results with .NET 5 TFMs when platforms are used, like net5.0-windows.
If you see other usage of it, it may be worthwhile to take note. @zkat, perhaps we need to do a find all references to DotnetFrameworkName and determine which ones might cause NuGet to not work correctly in .NET 5.
rrelyea
approved these changes
Sep 21, 2020
dtivel
added a commit
that referenced
this pull request
Sep 23, 2020
This was referenced Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10055
Regression: No
Fix
Details: Send all well-known project metadata back at once in a
IProjectMetadataContextInfoobject.I received feedback that retrieving project metadata one value at a time is suboptimal for high latency connections and does not follow VS OE API design guidance. This approach resolves that concern while at the same time fixing NuGet/Home#10055.
A logical next step might be to cache
IProjectMetadataContextInfoclient side, but that comes with it's own set of problems.I moved formatter tests under a
Formattersfolder to have symmetry with the product project.Testing/Validation
Tests Added: Yes