Support Push/Delete to http server and file system#253
Support Push/Delete to http server and file system#253yugangw-msft wants to merge 15 commits intodevfrom
Conversation
|
Hi @yugangw-msft, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
bda2b81 to
58058a9
Compare
| { | ||
| throw new ArgumentNullException(nameof(uri)); | ||
| } | ||
| if (nonInteractive) |
There was a problem hiding this comment.
There should be an empty line above this.
|
NuGet.Protocol.Core.v2 should not be used, this project will be deleted soon. V2 here means Legacy NuGet.Core resources, not OData V2. The resources can still be called V2 but they go into NuGet.Protocol.Core.v3. Take a look at the FindPackageById resources which have v2 implementations in the V3 project. Everything needed for STS auth and the handler resource are already in NuGet.Protocol.Core.v3 so this code should not need to be copied. There have been recent changes to clean up HttpSource. Instead of getting an httpmessagehandler resource you can now get the HttpSourceResource which will give you the single instance HttpSource for the endpoint. HttpSource.Create(source) can be used also. |
|
⌚ |
58058a9 to
b6f58ad
Compare
63f8156 to
b98d757
Compare
|
CC @emgarten please review. |
b98d757 to
02c23a4
Compare
There was a problem hiding this comment.
Going forward I'd suggest using a platform trait to indicate platform specific tests like this
[Fact]
[Trait("Platform", "WindowsOnly")]
public void PushCommand_PushToFileSystemSourceUncStyle()
{
...
}Having the trait one can invoke xunit runner with -ExcludeTraits "Platform=WindowsOnly"
There was a problem hiding this comment.
yep, this option looks good me. CC @deepakaravindr
|
🚀 |
02c23a4 to
d8b4f42
Compare
…friend assemblies
|
I merged the same change through #262 for simpler commit history. |
EDIT: CI passed