Refactoring msbuild related string utility methods#1053
Merged
Conversation
rohit21agrawal
approved these changes
Dec 13, 2016
joelverhagen
approved these changes
Dec 13, 2016
Member
|
@mishra14 why this change made? These are helper methods for MSBuild which is at a higher level than NuGet.Commands. Everything that needs to work with MSBuild should also be using NuGet.Commands. The name StringUtility is very misleading, any user who adds one of the NuGet.* packages could end up getting this MSBuild helper utility under the name StringUtility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emgarten @joelverhagen @rohit21agrawal