fix for icons not getting added to torrent #2932
Merged
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding torrents with magnet links in stopped state and starting this torrent will download meta data and change name from hash.meta to torrent name and stay in stopped state, but because icon was changed before name change the icon was added to last DOM element and now the torrent dont have icon in torrent list or in RSS list. If we do icon change after then its always there. If changing the view that this torrent is not in the list and change back where it is the icon will appear, but with this change its always there.
Collaborator
|
Thanks! |
stickz
added a commit
to stickz/docker-rutorrent
that referenced
this pull request
May 25, 2025
# ruTorrent v5.2.6 This is an important hotfix. It's recommended to upgrade. 1. It resolves a couple annoying bugs and glitches with the torrent status icons. (Thanks ranirahn) 2. It adds full Brazilian Portuguese translations to ruTorrent. (Thanks cantalupo555) ## What's Changed * l10n: Improve Brazilian Portuguese translations by cantalupo555 in Novik/ruTorrent#2934 * fix for icons not getting added to torrent by ranirahn in Novik/ruTorrent#2932 * fix for status icons added to wrong column by ranirahn in Novik/ruTorrent#2936 * feat(i18n): Add pt-BR translations for multiple plugins by cantalupo555 in Novik/ruTorrent#2938 ## New Contributors * cantalupo555 made their first contribution in Novik/ruTorrent#2934 **Full Changelog**: Novik/ruTorrent@v5.2.5...v5.2.6
stickz
added a commit
to stickz/docker-rtorrent-rutorrent
that referenced
this pull request
May 25, 2025
**Full Changelog**: Novik/ruTorrent@v5.2.5...v5.2.6 # ruTorrent v5.2.6 This is an important hotfix. It's recommended to upgrade. 1. It resolves a couple annoying bugs and glitches with the torrent status icons. (Thanks ranirahn) 2. It adds full Brazilian Portuguese translations to ruTorrent. (Thanks cantalupo555) ## What's Changed * l10n: Improve Brazilian Portuguese translations by cantalupo555 in Novik/ruTorrent#2934 * fix for icons not getting added to torrent by ranirahn in Novik/ruTorrent#2932 * fix for status icons added to wrong column by ranirahn in Novik/ruTorrent#2936 * feat(i18n): Add pt-BR translations for multiple plugins by cantalupo555 in Novik/ruTorrent#2938 ## New Contributors * cantalupo555 made their first contribution in Novik/ruTorrent#2934
This was referenced May 25, 2025
4 tasks
stickz
pushed a commit
that referenced
this pull request
May 30, 2025
When adding torrents with magnet links in stopped state and starting this torrent will download meta data and change name from hash.meta to torrent name and stay in stopped state, but because icon was changed before name change the icon was added to last DOM element and now the torrent dont have icon in torrent list or in RSS list. If we do icon change after then its always there. If changing the view that this torrent is not in the list and change back where it is the icon will appear, but with this change its always there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding torrents with magnet links in stopped state and starting this torrent will download meta data and change name from hash.meta to torrent name and stay in stopped state, but because icon was changed before name change the icon was added to last DOM element and now the torrent dont have icon in torrent list or in RSS list. If we do icon change after then its always there. If changing the view that this torrent is not in the list and change back where it is the icon will appear, but with this change its always there. Did not change the code, just reorder the IF statements.