[train][CI] Skip verifiers integration tests#729
Merged
SumanthRH merged 3 commits intoNovaSky-AI:mainfrom Dec 3, 2025
Merged
Conversation
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses failing integration tests by skipping them. The approach of using a pytest.mark.skip is appropriate. I've provided one suggestion to make the implementation more idiomatic by including the reason for skipping directly in the marker, which will improve test reporting and maintainability.
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
# What does this PR do? Skips verifiers tests the right way. NovaSky-AI#656 tried to skip failing tests but just moving the file outside of `gpu_ci` is not enough. this stil led to test failures: 1. CI script executed: `uv run --directory . --isolated --extra dev --extra vllm --with verifiers pytest -s tests/gpu/gpu_ci/ -m integrations` 2. No tests with marker `integrations` were found in `gpu/gpu_ci` ( as expected). The command fails with exit code 5 3. Since the GPU CI script uses `set -xeuo pipefail` , the script fails. The better fix is to skip the test temporarily with the skip marker. The reason we skip the tests is that verifiers did a major refactor where they removed `GenerateInputs` object: https://github.com/PrimeIntellect-ai/verifiers/pull/549/files#diff-8bc45ba080ed8ff01ee6adbafb54c0346181c6f292928e53c2a94dd9ed5156c3 . This causes the integration test to fail. We will fix this very soon: NovaSky-AI#708 --------- Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skips verifiers tests the right way.
#656 tried to skip failing tests but just moving the file outside of
gpu_ciis not enough. this stil led to test failures:uv run --directory . --isolated --extra dev --extra vllm --with verifiers pytest -s tests/gpu/gpu_ci/ -m integrationsintegrationswere found ingpu/gpu_ci( as expected). The command fails with exit code 5set -xeuo pipefail, the script fails.The better fix is to skip the test temporarily with the skip marker.
The reason we skip the tests is that verifiers did a major refactor where they removed
GenerateInputsobject: https://github.com/PrimeIntellect-ai/verifiers/pull/549/files#diff-8bc45ba080ed8ff01ee6adbafb54c0346181c6f292928e53c2a94dd9ed5156c3 . This causes the integration test to fail. We will fix this very soon: #708