Skip to content

fix(cli): show history when resuming a session#9494

Closed
CartericAdmin wants to merge 1 commit into
NousResearch:mainfrom
CartericAdmin:pr/fix-resume-history
Closed

fix(cli): show history when resuming a session#9494
CartericAdmin wants to merge 1 commit into
NousResearch:mainfrom
CartericAdmin:pr/fix-resume-history

Conversation

@CartericAdmin

Copy link
Copy Markdown

Summary

  • show the resumed conversation recap when using /resume <session> inside the CLI
  • route resumed history rendering through the TUI-safe output path when prompt_toolkit is active
  • add a regression test covering /resume history display

Test Plan

  • python -m pytest tests/cli/test_cli_init.py tests/cli/test_resume_display.py -q

(cherry picked from commit 6f61a2816f3d6a32e76fe928c0e3861e9a60faf9)
@CartericAdmin

Copy link
Copy Markdown
Author

Quick maintainer note:

This came out of real usage in a custom Hermes fork. The issue was that startup resume already showed the prior conversation recap, but mid-session /resume <session> only printed the one-line "resumed session" summary and did not show the actual prior history.

What changed:

  • /resume <session> now also renders the resumed conversation recap when messages exist
  • resumed history rendering uses the TUI-safe output path when prompt_toolkit is active

Validation:

  • python -m pytest tests/cli/test_cli_init.py tests/cli/test_resume_display.py -q

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related to #7480 and #10708 — overlapping PRs addressing /resume recap display. Maintainer should consolidate.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by PR #31695 (merged), which bundles this fix and several sibling PRs in the /resume recap cluster.

PR #31695 wires _display_resumed_history() into in-session /resume (the missing 1-line bug fix) AND exposes the recap truncation limits + tool-call-only skip as configurable display.* keys. Eight contributors independently filed PRs against this same UX gap — thanks for being one of them.

Authorship for the cherry-picked commits is preserved in git log via rebase-merge. If your PR included specific behavior that PR #31695 missed, please reopen with a follow-up scoped to that delta.

(Bulk-closed during a CLI PR triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants