fix(cli): honor resume_display full mode without truncation#10708
Closed
JorkeyLiu wants to merge 1 commit into
Closed
fix(cli): honor resume_display full mode without truncation#10708JorkeyLiu wants to merge 1 commit into
JorkeyLiu wants to merge 1 commit into
Conversation
The 'full' resume_display setting was misleading — it still truncated user messages to 300 chars, assistant messages to 200 chars / 3 lines, and limited display to the last 10 exchanges. Changes: - 'full' mode now shows complete conversation history without truncation - Added 'compact' mode preserving the old truncated behavior - /resume mid-conversation now calls _display_resumed_history() to show the recap panel (previously only printed a one-liner) - Updated tests: truncation tests use 'compact', added new 'full' mode tests verifying no truncation occurs
Contributor
|
Closing as superseded by PR #31695 (merged), which bundles this fix and several sibling PRs in the PR #31695 wires Authorship for the cherry-picked commits is preserved in (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fix the
resume_display: fullconfig setting which was still truncating messages despite the name.Why: The 'full' mode applied hard-coded truncation limits:
This was misleading — users who set
fullexpected complete history.Additionally, the
/resumemid-conversation command only printed a one-liner summary without showing the previous conversation recap panel.How:
fullmode now shows all messages without content truncation or exchange limitscompactmode preserving the old truncated behavior for users who prefer it/resumecommand now calls_display_resumed_history()to show the recap panel (consistent with startup resume behavior)compact, added new tests forfullmodeHow to test:
resume_display: compactin config.yaml — should see truncated recap/resumemid-conversation — should show recap panelPlatforms tested: macOS (CLI), 32/32 resume display tests passing