Bugfix: recover from structured reasoning budget exhaustion#9452
Open
HiddenPuppy wants to merge 3 commits into
Open
Bugfix: recover from structured reasoning budget exhaustion#9452HiddenPuppy wants to merge 3 commits into
HiddenPuppy wants to merge 3 commits into
Conversation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Hermes already had a thinking-budget guard for inline
<think>content, but OpenAI-compatible models likeglm-5-turbooften return reasoning viareasoning_content/reasoning_detailswith emptycontent. Those responses skipped the guard, then walked into continuation or prefill retries that grew context further without ever giving compression a chance.Notes
_last_content_with_toolsfallback issue from [Bug]: _last_content_with_tools fallback bypasses empty-response retries, causing silent agent loop termination mid-task #7968 is tracked independently in Bugfix: avoid stale tool-turn fallback on empty responses #9432 and is intentionally not duplicated here.Validation
git diff --checkpython3 -m py_compile run_agent.py tests/run_agent/test_run_agent.pypytestwas not runnable locally in this environment because the machine does not currently have the repo's required Python 3.11 + dev test toolchain installed.Closes #9344