Bugfix: avoid stale tool-turn fallback on empty responses#9432
Closed
HiddenPuppy wants to merge 2 commits into
Closed
Bugfix: avoid stale tool-turn fallback on empty responses#9432HiddenPuppy wants to merge 2 commits into
HiddenPuppy wants to merge 2 commits into
Conversation
b3e48d1 to
dbd90f6
Compare
Contributor
|
Closing — the core fix here (don't use substantive tool turn content as fallback) already exists on main via the Your regression tests were well-written — thanks @HiddenPuppy for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_last_content_with_toolswhen every tool call in the turn is housekeeping-onlyRoot Cause
Hermes cached visible assistant content from any turn that also contained tool calls. When the next model response came back empty, the loop could reuse that earlier content as the final answer even if the tool turn represented in-progress multi-step work.
Validation
git diff --checkpython3 -m py_compile run_agent.pypython3 -m py_compile tests/run_agent/test_run_agent.pypytestwas not runnable locally in this environment because the machine does not currently have the repo's required Python 3.11 + dev test toolchain installed.Closes #9400