test(gateway): regression test for /stop not suspending session (#9241)#9242
Open
r266-tech wants to merge 2 commits into
Open
test(gateway): regression test for /stop not suspending session (#9241)#9242r266-tech wants to merge 2 commits into
r266-tech wants to merge 2 commits into
Conversation
…ousResearch#9241) PR NousResearch#9224 removed suspend_session() from /stop but existing tests only check message text. Add test_stop_does_not_suspend_session covering all three code paths (sentinel, running agent, no-op) to prevent accidental revert.
…n each /stop path Codex adversarial review (confidence 0.91): path 1 did not verify sentinel removal after /stop, could mask regression. Added explicit assertions for _running_agents cleanup in paths 1 and 2.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #9224 removed
suspend_session()from/stopto prevent users from losing their conversation history. The updated tests only check message text — none verify thatsuspend_session()is not called on the session store.This adds
test_stop_does_not_suspend_sessioncovering all three/stopcode paths:If
suspend_session()is ever re-added to any/stoppath, this test fails immediately.Fixes #9241
Known limitations (from adversarial review)
suspend_sessionguard. Agent interrupt and session unlock behaviors are already covered by Tests 6, 6b, 6c in the same file.reset_mock()+_running_agentsmutations.Test plan
pytest tests/gateway/test_session_race_guard.py -k test_stop_does_not_suspend_session -vsuspend_session()is re-added to any/stoppath