Skip to content

test(gateway): guard /stop against session suspension regression#9457

Open
Lubrsy706 wants to merge 4 commits into
NousResearch:mainfrom
Lubrsy706:test-stop-suspend-session-regression
Open

test(gateway): guard /stop against session suspension regression#9457
Lubrsy706 wants to merge 4 commits into
NousResearch:mainfrom
Lubrsy706:test-stop-suspend-session-regression

Conversation

@Lubrsy706

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds regression coverage for the post-#9224 /stop behavior so future changes cannot reintroduce session_store.suspend_session() in the active-agent stop paths.

Why?

Issue #9241 calls out a missing regression test after #9224 removed the unintended session reset behavior from /stop.

How to test

  • ./venv/bin/python -m pytest tests/gateway/test_session_race_guard.py -q
  • ./venv/bin/python -m pytest tests/gateway/test_command_bypass_active_session.py -q

Platforms tested

  • macOS

Related issues

@Lubrsy706

Copy link
Copy Markdown
Contributor Author

Following up on this PR. The regression test should be ready for review from my side; if you would like any adjustments or broader coverage around session suspension handling, I can update it. Would appreciate a review when someone has time.

@Lubrsy706 Lubrsy706 force-pushed the test-stop-suspend-session-regression branch 2 times, most recently from 89691cc to 51b501a Compare April 20, 2026 02:47
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery labels Apr 27, 2026
@Lubrsy706 Lubrsy706 force-pushed the test-stop-suspend-session-regression branch from 65139c0 to 844729f Compare May 15, 2026 03:16
@Lubrsy706 Lubrsy706 force-pushed the test-stop-suspend-session-regression branch from 844729f to c09507f Compare May 15, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: /stop regression test missing suspend_session guard (post-#9224)

2 participants