fix(config): include model in custom_providers dedup key#9233
Closed
akhater wants to merge 1 commit into
Closed
Conversation
get_compatible_custom_providers() deduplicates by (name, base_url) which collapses multiple models under the same provider into a single entry. For example, 7 Ollama Cloud entries with different models become 1. Adding model to the tuple preserves all entries.
2 tasks
Contributor
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
… grouping Tests for salvaged PRs NousResearch#9233 and NousResearch#8011.
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
… grouping Tests for salvaged PRs NousResearch#9233 and NousResearch#8011.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
… grouping Tests for salvaged PRs NousResearch#9233 and NousResearch#8011.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
… grouping Tests for salvaged PRs NousResearch#9233 and NousResearch#8011.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
… grouping Tests for salvaged PRs NousResearch#9233 and NousResearch#8011.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_compatible_custom_providers()deduplicates entries by(name, base_url), which collapses multiple models under the same provider into a single entry/modelpicker then shows "Ollama Cloud (1)" instead of "Ollama Cloud (7)"Fix
Add
modelto the dedup tuple:(name, base_url, model). Entries with the same provider name and URL but different models are now preserved.Test plan
get_compatible_custom_providers()/modelpicker shows correct count🤖 Generated with Claude Code