fix: add missing packages to setuptools config#912
Merged
Conversation
20 tasks
- Add `agent`, `tools.*`, `gateway.*` to packages.find include - Add `hermes_state`, `hermes_time`, `mini_swe_runner`, `rl_cli`, `utils` to py-modules - Move rl_training_tool LOGS_DIR to ~/.hermes/logs/rl_training/ (was writing into the package source tree, which fails on read-only installs) These were masked in development (editable installs see the whole source tree) but broke any non-editable install like `pip install .` or wheel builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
986ae3f to
1d4a23f
Compare
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
fix: add missing packages to setuptools config
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
fix: add missing packages to setuptools config
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
fix: add missing packages to setuptools config
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
fix: add missing packages to setuptools config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent,tools.*,gateway.*to[tool.setuptools.packages.find] include— these sub-packages were missing, causingModuleNotFoundErroron non-editable installs. This is needed for feat: nix flake — uv2nix build, NixOS module, persistent container mode #20'snix buildhermes_state,hermes_time,mini_swe_runner,rl_cli,utils) topy-modulesrl_training_tool.pyLOGS_DIRto~/.hermes/logs/rl_training/— was writing into the package source tree, which is read-only in non-editable installsContext
These bugs were masked in development because
pip install -e .(editable mode) puts the entire source tree onsys.pathand the source tree is writable. Any non-editable install (pip install ., wheel build,nix build) would fail with missing module errors or crash trying to mkdir into a read-only package directory.