fix: strip <thought> tags from Gemma 4 responses#8562
Merged
Conversation
Gemma 4 (26B/31B) uses <thought>...</thought> to wrap its reasoning output. This tag was not included in the existing list of reasoning tag variants stripped by _strip_think_blocks(), causing raw thinking blocks to leak into the visible response. Added a new re.sub() line for <thought> and extended the cleanup regex to include 'thought' alongside the existing variants. Fixes #6148
auxiliary_client.py had its own regex mirroring _strip_think_blocks but was missing the <thought> variant. Also adds test coverage for <thought> paired and orphaned tags.
dev-xyz-0-0
added a commit
to dev-xyz-0-0/hermes-agent
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemma 4 (26B/31B) wraps inline reasoning in
<thought>...</thought>tags, which were leaking into visible responses. Salvaged from PR #6149 by @Unayung.Changes
<thought>to_strip_think_blocks()regex (cherry-picked from fix: strip <thought> tags from Gemma 4 responses in _strip_think_blocks #6149)<thought>/</thought>to streaming tag filter (cherry-picked from fix: strip <thought> tags from Gemma 4 responses in _strip_think_blocks #6149)thoughtto the mirrored regex that was missed by fix: strip <thought> tags from Gemma 4 responses in _strip_think_blocks #6149test_thought_block_removedandtest_orphaned_thought_tagTest results
Fixes #6148. Salvaged from #6149 — contributor commits cherry-picked with authorship preserved.