Skip to content

fix(skills): follow symlinked local skill dirs#8357

Closed
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/issue-8293-symlinked-skills
Closed

fix(skills): follow symlinked local skill dirs#8357
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/issue-8293-symlinked-skills

Conversation

@iacker

@iacker iacker commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make skill discovery follow directory symlinks under local/external skill roots
  • reuse iter_skill_index_files() so skills_list, skills_categories, and bare-name skill_view() share the same traversal behavior
  • add regression tests for symlinked local skills in discovery and bare-name lookup

Testing

  • source /Users/billard/hermes-agent/venv/bin/activate && python -m pytest tests/tools/test_skills_tool.py -q
  • source /Users/billard/hermes-agent/venv/bin/activate && python -m pytest tests/agent/test_external_skills.py -q

Closes #8293

@iacker iacker mentioned this pull request Apr 21, 2026
Closed
23 tasks
@teknium1

teknium1 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @iacker! This fix has been implemented on main.

This is an automated hermes-sweeper review.

  • The core change you proposed — followlinks=True in iter_skill_index_files() — landed in commit 02aba4a72 (fix(skills): follow symlinks in iter_skill_index_files).
  • A broader follow-up (a884f6d5d, fix(skills): follow symlinked category dirs consistently) also rewired _find_all_skills() and scan_skill_commands() to share the same traversal, and added regression tests covering symlinked skill and category directories — matching all three goals stated in your PR summary.
  • agent/skill_utils.py line 438 now reads os.walk(skills_dir, followlinks=True) on current main.
  • Issue Bug: symlinked skills under ~/.hermes/skills are omitted from skills_list and bare-name skill_view lookup #8293 is resolved by these commits.

Closing as implemented on main.

@teknium1 teknium1 closed this Apr 28, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) duplicate This issue or pull request already exists labels Apr 28, 2026
@alt-glitch

alt-glitch commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Duplicate of #14230 (merged) — same fix: followlinks=True in skill discovery. See also #8769, #7634, #12624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: symlinked skills under ~/.hermes/skills are omitted from skills_list and bare-name skill_view lookup

3 participants

@iacker @teknium1 @alt-glitch