fix(skills): follow symlinks in iter_skill_index_files (salvage #11847)#14230
Merged
Conversation
os.walk() by default does not follow symlinks, causing skills linked via symlinks to be invisible to the skill discovery system. Add followlinks=True so that symlinked skill directories are scanned.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #11847 by @xandersbell onto current main (substantive commit 6d5d2e9; the PR's other commits were stale-branch merge commits).
Passes
followlinks=Truetoos.walk()initer_skill_index_files. Users who symlink their~/.hermes/skills/directory to a dotfiles repo or shared location previously had their skills invisible to discovery —os.walkskips symlinked directories by default. This matches how skill discovery already walks into the user's skills dir as a regular traversal.Closes #11847. Author attribution preserved via cherry-pick.