fix(cron): handle naive legacy timestamps in due-job checks by 0xNyk · Pull Request #807 · NousResearch/hermes-agent

0xNyk · 2026-03-10T03:40:18Z

Summary

update cron.jobs._ensure_aware to normalize datetimes into Hermes configured timezone
interpret naive datetimes as system-local wall time before conversion
keep aware datetimes normalized via astimezone

Why

Legacy cron job rows may store next_run_at without timezone info.
When Hermes timezone differs from system local timezone, direct tz attachment can shift absolute time and incorrectly mark overdue jobs as not due.

Validation

python -m pytest tests/test_timezone.py::TestCronTimezone::test_get_due_jobs_handles_naive_timestamps -q
python -m pytest tests/cron/test_jobs.py tests/test_timezone.py tests/tools/test_cronjob_tools.py -q
- 75 passed, 3 skipped

Closes #806

0xNyk · 2026-03-10T03:41:57Z

Maintainer ping for triage: this is a narrow bugfix for legacy cron timestamps.

What it changes:

naive next_run_at values are interpreted as system-local wall time, then converted to Hermes timezone
aware timestamps are normalized to Hermes timezone before comparisons

Why:

fixes false not-due results when HERMES_TIMEZONE differs from local system timezone
directly addresses new bug report [Bug]: get_due_jobs may skip legacy naive timestamps under non-local Hermes timezone #806

Validation:

targeted timezone repro passes
cron/timezone related suites pass (75 passed, 3 skipped)

Cherry-picked from PR #807 by 0xNyk, rebased onto current main. When HERMES_TIMEZONE differs from system local timezone, naive (legacy) timestamps were misinterpreted by _ensure_aware() — it stamped them with the Hermes timezone via replace(tzinfo=...), but they were created using datetime.now() (system local time). This could shift the absolute time and cause overdue jobs to appear not-due. Fix: interpret naive datetimes as system-local wall time first, then convert to Hermes timezone. Already-aware datetimes are normalized to Hermes timezone for consistent comparisons. Added 3 tests: - _ensure_aware preserves absolute time for naive datetimes - _ensure_aware normalizes aware datetimes to Hermes tz - get_due_jobs detects naive past timestamps as due even when Hermes tz is far behind system local tz (the scenario from #806) Fixes #806 Co-authored-by: Nyk <0xnykcd@googlemail.com>

Legacy cron job rows may store next_run_at without timezone info. _ensure_aware() previously stamped the Hermes-configured tz directly via replace(tzinfo=...), which shifts absolute time when system-local tz differs from Hermes tz — causing overdue jobs to appear not due. Now: naive datetimes are interpreted as system-local wall time first, then converted to Hermes tz. Aware datetimes are normalized to Hermes tz for consistency. Cherry-picked from PR #807, rebased onto current main. Fixes #806 Co-authored-by: 0xNyk <0xNyk@users.noreply.github.com>

Three new tests for the naive timestamp fix (PR #807): - test_ensure_aware_naive_preserves_absolute_time: verifies UTC equivalent is preserved when interpreting naive datetimes as system-local time - test_ensure_aware_normalizes_aware_to_hermes_tz: verifies already-aware datetimes are normalized to Hermes tz without shifting the instant - test_ensure_aware_due_job_not_skipped_when_system_ahead: end-to-end regression test for the original bug scenario

Cherry-picked from PR NousResearch#807 by 0xNyk, rebased onto current main. When HERMES_TIMEZONE differs from system local timezone, naive (legacy) timestamps were misinterpreted by _ensure_aware() — it stamped them with the Hermes timezone via replace(tzinfo=...), but they were created using datetime.now() (system local time). This could shift the absolute time and cause overdue jobs to appear not-due. Fix: interpret naive datetimes as system-local wall time first, then convert to Hermes timezone. Already-aware datetimes are normalized to Hermes timezone for consistent comparisons. Added 3 tests: - _ensure_aware preserves absolute time for naive datetimes - _ensure_aware normalizes aware datetimes to Hermes tz - get_due_jobs detects naive past timestamps as due even when Hermes tz is far behind system local tz (the scenario from NousResearch#806) Fixes NousResearch#806 Co-authored-by: Nyk <0xnykcd@googlemail.com>

Legacy cron job rows may store next_run_at without timezone info. _ensure_aware() previously stamped the Hermes-configured tz directly via replace(tzinfo=...), which shifts absolute time when system-local tz differs from Hermes tz — causing overdue jobs to appear not due. Now: naive datetimes are interpreted as system-local wall time first, then converted to Hermes tz. Aware datetimes are normalized to Hermes tz for consistency. Cherry-picked from PR NousResearch#807, rebased onto current main. Fixes NousResearch#806 Co-authored-by: 0xNyk <0xNyk@users.noreply.github.com>

Three new tests for the naive timestamp fix (PR NousResearch#807): - test_ensure_aware_naive_preserves_absolute_time: verifies UTC equivalent is preserved when interpreting naive datetimes as system-local time - test_ensure_aware_normalizes_aware_to_hermes_tz: verifies already-aware datetimes are normalized to Hermes tz without shifting the instant - test_ensure_aware_due_job_not_skipped_when_system_ahead: end-to-end regression test for the original bug scenario