chore: fix vision test by mocking aux client#803
Closed
OutThisLife wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks for the fix @OutThisLife! This was already independently fixed on main in commit 0229e6b by @SHL0MS (same approach — mocking |
teknium1
added a commit
that referenced
this pull request
Mar 11, 2026
The weaker assertion (r.exc_info is not None) passes even when exc_info is (None, None, None). Check r.exc_info[0] is not None to verify actual exception info is present. The _aux_async_client mock was already applied on main. Co-authored-by: OutThisLife <nickolasgustafsson@gmail.com>
Contributor
|
The _aux_async_client mock was already on main (reformatted to PEP8 parens in a prior commit). Your tighter exc_info assertion (r.exc_info and r.exc_info[0] is not None) has been applied in 184aa5b. Thanks — co-authored-by credit included. |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_analysis_error_logs_exc_infofails in CI but passes locally. The test doesn't mock_aux_async_client, so when another test leaves that global asNone, the function early-returns before reaching theexceptblock — no error is ever logged, assertion fails.Related Issue
N/A
Type of Change
Changes Made
tests/tools/test_vision_tools.py: mock_aux_async_clientto a truthy value so the code reaches the download/exception pathr.exc_info is not Nonetor.exc_info and r.exc_info[0] is not None(the former passes even when there's no real exception)How to Test
python -m pytest tests/tools/test_vision_tools.py::TestErrorLoggingExcInfo -xvsChecklist
Code
make check(lint + test) and all checks passDocumentation & Housekeeping