Skip to content

fix: add gpt-5.4 to openai-codex model picker#7670

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-03da22bc
Apr 11, 2026
Merged

fix: add gpt-5.4 to openai-codex model picker#7670
teknium1 merged 1 commit into
mainfrom
hermes/hermes-03da22bc

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

ChatGPT OAuth users couldn't see gpt-5.4 or gpt-5.4-mini in the /model picker on Telegram/Discord.

Root cause: _PROVIDER_MODELS['openai-codex'] in hermes_cli/models.py was never updated when gpt-5.4 became available. It only had the older codex-specific models (gpt-5.3-codex, gpt-5.2-codex, etc.). Meanwhile, codex_models.py's DEFAULT_CODEX_MODELS already included gpt-5.4 and gpt-5.4-mini.

The /model interactive picker (Telegram inline keyboards, Discord buttons) calls list_authenticated_providers() which pulls from the _PROVIDER_MODELS curated list — not from codex_models.py.

Fix: Add gpt-5.4 and gpt-5.4-mini to the top of the openai-codex curated list, matching what codex_models.py already has.

Test plan

  • 161 model-related tests pass (test_models, test_codex_models, test_model_switch, test_model_command, test_model_validation, test_model_normalize)
  • Verified import: _PROVIDER_MODELS['openai-codex'] now returns ['gpt-5.4', 'gpt-5.4-mini', 'gpt-5.3-codex', ...]

Reported by @chongdashu

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
@teknium1 teknium1 force-pushed the hermes/hermes-03da22bc branch from 5c6c00b to 082e3c1 Compare April 11, 2026 10:09
@teknium1 teknium1 merged commit 671d506 into main Apr 11, 2026
Tommyeds pushed a commit to Tommyeds/hermes-agent that referenced this pull request Apr 12, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
liaoyinglong pushed a commit to liaoyinglong/hermes-agent that referenced this pull request Apr 13, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
ulasbilgen pushed a commit to ulasbilgen/hermes-adhd-agent that referenced this pull request May 1, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
aj-nt pushed a commit to aj-nt/hermes-agent that referenced this pull request May 1, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…ousResearch#7670)

The _PROVIDER_MODELS['openai-codex'] list was missing gpt-5.4 and gpt-5.4-mini,
causing them to not appear in the /model picker for ChatGPT OAuth users.
codex_models.py already had these models in DEFAULT_CODEX_MODELS, but the
curated list that feeds the Telegram/Discord /model picker was never updated.

Reported by @chongdashu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant