fix(nix): gate matrix extra to Linux in [all] profile#7461
Merged
Conversation
matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes #4594
Collaborator
Author
|
@BugBot review |
PR SummaryMedium Risk Overview Updates the packaging regression test to assert that Reviewed by Cursor Bugbot for commit ab95f74. Configure here. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ab95f74. Configure here.
23 tasks
1 task
arasovic
added a commit
to arasovic/hermes-agent
that referenced
this pull request
Apr 12, 2026
pip install -e .[all] hangs indefinitely on 32-bit ARM Linux hosts (Raspberry Pi 3B / 2 / Zero) because the unconditional hermes-agent[voice] entry in [all] pulls in faster-whisper, which transitively depends on ctranslate2 and onnxruntime. Neither package publishes wheels for armv6l / armv7l, so pip falls back to building from source, which either OOMs or fills tmpfs on 1GB-RAM devices. The Telegram /update command therefore never returns and the gateway hangs until the stuck pip process is killed manually. Gate the voice entry in [all] with a platform_machine environment marker, mirroring the [matrix]; sys_platform == 'linux' pattern merged in NousResearch#7461 and the existing termux extras' rationale (whose comment already calls out faster-whisper -> ctranslate2 as the reason the Termux path avoids voice). Users on ARM32 who genuinely need local STT can still install it explicitly via pip install -e '.[voice]'. Adds tests/test_packaging_metadata.py::test_all_extra_gates_voice_off_arm32 as a regression test using packaging.requirements.Requirement to resolve the marker against synthetic platform_machine values. Fixes NousResearch#8397
3 tasks
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
) * fix(nix): gate matrix extra to Linux in [all] profile matrix-nio[e2e] depends on python-olm which is upstream-broken on modern macOS (Clang 21+, archived libolm). Previously the [matrix] extra was completely excluded from [all], meaning NixOS users (who install via [all]) had no Matrix support at all. Add a sys_platform == 'linux' marker so [all] pulls in [matrix] on Linux (where python-olm builds fine) while still skipping it on macOS. This fixes the NixOS setup path without breaking macOS installs. Update the regression test to verify the Linux-gated marker is present rather than just checking matrix is absent from [all]. Fixes NousResearch#4594 * chore: regenerate uv.lock with matrix-on-linux in [all]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4594 — Matrix does not work on NixOS setup.
Problem
The
[matrix]extra was completely excluded from the[all]install profile becausepython-olm(a dependency ofmatrix-nio[e2e]) is upstream-broken on modern macOS (archived libolm, C++ errors with Clang 21+). This meant NixOS users — who typically install via[all]— got no Matrix support at all, even thoughpython-olmbuilds fine on Linux.Fix
Add a
sys_platform == 'linux'environment marker to the[all]profile entry:This pulls in Matrix support on Linux (including NixOS) while continuing to skip the broken macOS build. Users on macOS who need Matrix can still install manually via
pip install 'hermes-agent[matrix]'.Test changes
Updated
test_matrix_extra_linux_only_in_all()to verify:hermes-agent[matrix]is not unconditionally in[all](would break macOS)[all]Notes
[matrix]extra definition is untouched — the marker only affects the[all]aggregate.matrix-niowithmautrix) is tracked separately.