feat(nix): add overlay and make package overridable#7229
Closed
yzx9 wants to merge 3 commits into
Closed
Conversation
136ceb5 to
8d3c588
Compare
Collaborator
|
@BugBot review |
Collaborator
|
fixed in #7461 |
Contributor
Author
|
Thanks for your quick response and the fix! Even with #7461 in place, I believe this PR is still valuable because it makes the Nix packages overridable. I’d still be happy to see this PR move forward. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the Nix experience, especially when overriding the package.
Related Issue
Fixes #4594
Type of Change
Changes Made
dependency-groupsas a parameter for more flexible builds.nix/packages.nixto a new, modularizednix/hermes-agent.nix, improving maintainability and reusability.dependency-groupsas a parameter for more flexible builds.nix/overlays.nix, providing a Nix overlay that exposes the Hermes Agent package for easier consumption in external Nix projects.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs