Related: #9555 (handoff payload to delegated children) and #9557 (adaptive delegation policy) are complementary — this PR gives named targets, those give the data a policy needs to pick between them intelligently.

Orb Code Review (powered by GLM 5.1 on Orb Cloud)

PR #7201 — feat: add named delegation routing profiles

What it does

Replaces the flat delegation.model/provider/base_url/api_key config with named routing profiles (delegation.routes.<name>), adds per-task routing_profile selection, includes config migration, and comprehensive validation.

Observations

✅ Excellent design

• Named routes allow different subagent tasks to use different provider:model pairs
• Per-task routing_profile override in batch mode is well-designed
• _normalize_delegation_config() bridges legacy flat config and new route-based config seamlessly
• Config migration in migrate_config() properly moves legacy keys into routes.default

✅ Strong validation and error messages

• validate_config_structure() checks route types, field types, missing default route, unknown route references
• Error messages reference the specific route name (e.g., "route 'research'") which aids debugging
• _validate_inherited_route_model() catches provider/model mismatches early

✅ Comprehensive test coverage

• Tests cover normalization, route resolution, legacy migration, validation, batch per-task routing, and error cases
• 8+ new test methods covering edge cases

⚠️ Minor: narrow provider validation
_validate_inherited_route_model() only checks for openai-codex provider with / in the model name:

if parent_provider == "openai-codex" and "/" in configured_model:

This handles one specific case. Other providers may have similar constraints. Consider making this more general or documenting why only openai-codex needs this check.

⚠️ Minor: dual normalization paths
Config normalization exists in two places:

1. delegate_tool.py::_normalize_delegation_config() — runtime
2. hermes_cli/config.py::migrate_config() — persistent migration

Both must stay in sync. A comment cross-referencing them would help future maintainers.

Summary: Well-designed feature with thorough migration, validation, and test coverage. Named routing profiles are a significant improvement over flat delegation config. Minor notes about the narrow provider validation and dual normalization paths.

Assessment: approve

Follow-up after reviewing the current PR comments and re-validating the refreshed branch:

• The complementary-note comment about [Feature]: Structured handoff payload for delegate_task so children don't re-explore #9555 / [Feature]: Adaptive delegation policy — learn which tasks pay off delegating #9557 doesn't require a code change here; it reads as architectural context, not a gap in this PR.
• I DID take the Orb review's two minor notes: added explicit cross-reference comments between the runtime delegation normalization path (tools.delegate_tool._normalize_delegation_config) and the persistent migration path (hermes_cli.config.migrate_config), and documented why the inherited-provider model guard is intentionally narrow to the known openai-codex mismatch case.
• While re-running the targeted validation slice, I also found and fixed a real correctness issue in batch mode: an unknown per-task routing_profile could be masked by credential resolution on an earlier task. The branch now validates all requested routing profiles before any child-agent build/credential work starts, so the batch fails on the intended route error first.

Validation after the follow-up commit:

• tests/tools/test_delegate.py tests/hermes_cli/test_config.py → 129 passed
• tests/tools/test_delegate_toolset_scope.py → 5 passed

The incremental follow-up commit is PR-scoped only and touches:

• tools/delegate_tool.py
• hermes_cli/config.py