Skip to content

fix(cli): override incorrect models.dev env mappings for providers (f…#6625

Closed
devorun wants to merge 1 commit into
NousResearch:mainfrom
devorun:patch-37
Closed

fix(cli): override incorrect models.dev env mappings for providers (f…#6625
devorun wants to merge 1 commit into
NousResearch:mainfrom
devorun:patch-37

Conversation

@devorun

@devorun devorun commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

…ixes minimax-cn) (#6620)

What does this PR do?

Fixes #6620

The Bug:
The /model command fails to list the minimax-cn provider even when MINIMAX_CN_API_KEY is set. This is because list_authenticated_providers() relies on data from the models.dev registry, which incorrectly maps minimax-cn to MINIMAX_API_KEY.

The Fix:
Instead of waiting for an upstream fix from models.dev, I added a scalable PROVIDER_ENV_OVERRIDES dictionary inside hermes_cli/model_switch.py. This safely overrides incorrect registry mappings before checking credentials. Currently, it maps minimax-cn to MINIMAX_CN_API_KEY, aligning the CLI detection logic with the actual credential resolution in auth.py.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

teknium1 added a commit that referenced this pull request Apr 9, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detection
e46cdf2 
list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes #6620. Based on devorun's investigation in PR #6625.
@teknium1 teknium1 mentioned this pull request Apr 9, 2026
Merged
teknium1 added a commit that referenced this pull request Apr 9, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
ee16416 
…on (#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes #6620. Based on devorun's investigation in PR #6625.
@teknium1

teknium1 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #6755 with a broader fix. Your investigation in the issue and PR correctly identified the root cause — models.dev returning the wrong env var name for minimax-cn. The fix was expanded to use auth.py's PROVIDER_REGISTRY as the authoritative source for env var names, which also fixes 4 other providers with the same class of mismatch (zai, opencode-zen, opencode-go, kilocode). Thanks @devorun!

@teknium1 teknium1 closed this Apr 9, 2026
Tommyeds pushed a commit to Tommyeds/hermes-agent that referenced this pull request Apr 12, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
2b7b6fb 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
3c985eb 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 28, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detection
778c851 
list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
bfaf137 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
92448c1 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
2925245 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
@teknium1
fix(cli): prefer auth.py env vars over models.dev in provider detecti…
8ec1ae6 
…on (NousResearch#6755)

list_authenticated_providers() was using env var names from the external
models.dev registry to detect credentials. This registry has incorrect
mappings for 5 providers: minimax-cn, zai, opencode-zen, opencode-go,
and kilocode — causing them to not appear in /model even when the
correct API key is set.

Now checks PROVIDER_REGISTRY from auth.py first (our source of truth),
falling back to models.dev only for providers not in our registry.

Fixes NousResearch#6620. Based on devorun's investigation in PR NousResearch#6625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] minimax-cn provider not shown in /model list despite MINIMAX_CN_API_KEY being set

2 participants

@devorun @teknium1