fix(security): prevent shell injection in sudo password piping#65
Merged
teknium1 merged 1 commit intoFeb 27, 2026
Merged
Conversation
The sudo password was embedded in shell commands via single-quote
interpolation: echo '{password}' | sudo -S
If the password contained shell metacharacters (single quotes,
$(), backticks), they would be interpreted by the shell, enabling
arbitrary command execution.
Fix: use shlex.quote() which properly escapes all shell-special
characters, ensuring the password is always treated as a literal
string argument to echo.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…-shell-injection fix(security): prevent shell injection in sudo password piping
alnimra
added a commit
to alnimra/hermes-agent
that referenced
this pull request
May 3, 2026
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…-shell-injection fix(security): prevent shell injection in sudo password piping
13 tasks
This was referenced Jun 9, 2026
v6.7 Tranche 1: kanban_complete verification gates (#28, #62, #64)
1Team-Engineering/hermes-agent#11
Merged
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…-shell-injection fix(security): prevent shell injection in sudo password piping
jarvis-stark-ops
added a commit
to 1Team-Engineering/hermes-agent
that referenced
this pull request
Jun 10, 2026
…arch#34, NousResearch#65) - NousResearch#33 GH_TOKEN propagation: _inject_gh_token_into_env runs `gh auth token` before each worker subprocess.Popen and injects into env if the worker doesn't have GH_TOKEN/GITHUB_TOKEN. - NousResearch#34 respawn_guarded active_pr exempts review roles (tony/tchalla/ vision/reviewer). Bounded: exemption only applies while consecutive_failures < max_retries; once exhausted the guard fires. - NousResearch#65 fabricated github-auth block claims rejected: FabricatedAuthClaimError raised when kanban_block reason matches auth-claim pattern AND dispatcher's `gh auth status` succeeds. Strict leading-position regex with cause:/blocker:/reason:/infra: prefix exemption. Context: hermes-jarvis#61. 33 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sudo password in
_transform_sudo_command()was embedded in a shell command using single-quote interpolation:If the password contained shell metacharacters (single quotes,
$(), backticks), they would escape the quoting and be interpreted by the shell — enabling arbitrary command execution.Example — a password like
test'; rm -rf / #produces:Fix
Use
shlex.quote()which properly handles all shell-special characters:The same attack payload now produces:
Scope
Single file, 3-line change in
tools/terminal_tool.py. No behavior change for normal passwords —shlex.quote()is a no-op for simple alphanumeric strings.