fix(gateway): handle windows pid probe failures#6310
Conversation
5e3a372 to
a246dd4
Compare
|
Thanks for this — appreciate the work. We're closing the entire cluster of open native-Windows PRs (44 of them spanning installer, terminal routing, file ops, gateway PID handling, encoding, docs, and more) because the surface area needs a designed, consolidated approach rather than piecemeal merges. Cherry-picking individual fixes keeps leaving inconsistencies and we'd rather land Windows support properly, in one coherent pass.\n\nYour PR is catalogued in our internal Windows support plan. When we pick this back up (soon), we'll mine every PR in the cluster for its fix shape and credit all contributors whose work informs the final patch via lines. Watch for the consolidating PR and feel free to chime in with context on the specific failure mode you were hitting.\n\nClosing for now, not as a rejection of the fix — just queueing it for the designed rollout. Thanks again. |
Summary
SystemError/OSErrorfailures fromos.kill(pid, 0)as stale PID recordsTesting
python -m pytest tests/gateway/test_status.py tests/hermes_cli/test_profiles.py -qpython -m pytest tests/gateway/ -q(fails on pre-existing unrelated test:tests/gateway/test_run_progress_topics.py::test_run_agent_progress_stays_in_originating_topicexpecting💻 terminal: "pwd"but current output is⚙️ terminal: "pwd")Closes #5760