fix(gateway): treat OSError from scoped-lock PID probe as stale#11156
Open
Yiyufadacai wants to merge 2 commits into
Open
fix(gateway): treat OSError from scoped-lock PID probe as stale#11156Yiyufadacai wants to merge 2 commits into
Yiyufadacai wants to merge 2 commits into
Conversation
Extend acquire_scoped_lock existence check to catch OSError from os.kill(pid, 0) on hosts where signal 0 fails with errno-style errors. Add regression test mirroring stale-lock recovery for ProcessLookupError. Made-with: Cursor
RuckVibeCodes
suggested changes
Apr 17, 2026
RuckVibeCodes
left a comment
There was a problem hiding this comment.
[gus-first-pass] Scoped lock handling should ensure reliability under various scenarios. Inline suggestions provided for correction.
19 tasks
Collaborator
…scoped-lock-oserror-probe # Conflicts: # gateway/status.py
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acquire_scoped_lock: when probing an existing lock owner viaos.kill(pid, 0), also treatOSErroras a stale/unusable lock (same recovery path asProcessLookupError/PermissionError). Some Windows and POSIX edge cases surface non-lookup failures asOSError.test_acquire_scoped_lock_replaces_stale_when_kill_raises_oserror.Test plan
pytest tests/gateway/test_status.py::TestScopedLocks -q -o addopts=Notes
get_running_pid()OSError handling discussed elsewhere.