fix: add edge-case regressions for path and timeout handling#11214
Open
wttAIxyy wants to merge 2 commits into
Open
fix: add edge-case regressions for path and timeout handling#11214wttAIxyy wants to merge 2 commits into
wttAIxyy wants to merge 2 commits into
Conversation
Cover cross-platform exception branches in scoped lock PID probing and ensure Copilot ACP accepts httpx Timeout objects to prevent runtime type errors. Made-with: Cursor
…atform-regression-tests # Conflicts: # gateway/status.py # tests/agent/test_copilot_acp_client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.kill(pid, 0)raisesOSErrorOSErroras stale-lock signal inacquire_scoped_lockto align with cross-platform process-probe behaviorhttpx.Timeoutinputs no longer raiseTypeErrorTest plan
pytest tests/gateway/test_status.py::TestScopedLocks::test_acquire_scoped_lock_replaces_stale_when_kill_raises_oserror -q -o addopts=pytest tests/agent/test_copilot_acp_client.py -q -o addopts=