You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Friendly ping — this one fixes a reproducible profile-creation bug where hermes profile create --clone-all can recursively copy profiles/ into itself when cloning from the default ~/.hermes profile. The patch is narrow and includes a regression test (tests/hermes_cli/test_profiles.py). Happy to adjust quickly if you want a different guard condition or test shape.
This fixes a real bug: hermes profile create --clone-all copies profiles/ into itself recursively when the source is ~/.hermes. Includes a regression test. Ready for review.
Thanks for the fix @iacker — this same bug (#4306) was fixed independently in commit 528e7dc on April 21 (PR by @hejuntt1014), which is already on main. Both fixes use the same approach: pass a copytree ignore callable that excludes the sibling profiles/ directory at the source root, plus a regression test. Closing as superseded. Appreciate you taking the time to dig into this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/cliCLI entry point, hermes_cli/, setup wizardtype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes profile create --clone-allfrom recursively copying theprofiles/directory when cloning from the default profile~/.hermesprofileTesting
source venv/bin/activate && python -m pytest tests/hermes_cli/test_profiles.py -qCloses #4306