fix(profiles): pass symlinks=True to copytree to prevent RecursionError#11829
Open
Mibayy wants to merge 2 commits into
Open
fix(profiles): pass symlinks=True to copytree to prevent RecursionError#11829Mibayy wants to merge 2 commits into
Mibayy wants to merge 2 commits into
Conversation
…onError (issue NousResearch#11560) shutil.copytree() with the default symlinks=False follows symlinks and can enter infinite recursion when the profile directory contains a circular or self-referential symlink (e.g. a skill directory that links back to a parent). Passing symlinks=True causes copytree to copy the link itself rather than following it, preventing the RecursionError. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c8ea8b4 to
638fbdb
Compare
Collaborator
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes profile create <name> --clone-allraisesRecursionErrorwhen the profile directory contains a symlink pointing to a parent directory.shutil.copytreefollows symlinks by default, causing infinite recursion.Changes
hermes_cli/profiles.py: addsymlinks=Trueto theshutil.copytreecall so symlinks are copied as symlinks rather than followedTesting
Profile creation with a directory containing a circular symlink no longer crashes.
Closes #11560