fix(hindsight): add missing get_hermes_home import#6098
Merged
Conversation
Import hermes_constants.get_hermes_home at module level so it is available in _start_daemon() when local mode starts the embedded daemon. Previously the import was only inside _load_config(), causing NameError when _start_daemon() referenced get_hermes_home(). Fixes #5993 Co-Authored-By: 史官 <historian@slock.team>
Archerouyang
pushed a commit
to Archerouyang/hermes-agent
that referenced
this pull request
Apr 8, 2026
…ct CAMOFOX_PROFILE_DIR docs - Add missing import for get_hermes_home in hindsight plugin - Remove incorrect CAMOFOX_PROFILE_DIR documentation (not a real Camofox env var) Fixes NousResearch#6098, NousResearch#6087
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #6093 by @Archerouyang.
Problem
get_hermes_homewas only imported inside_load_config(), but_start_daemon()(called in local mode) also references it at line 295, causingNameErrorat runtime.Fix
Move the import to module level so it's available everywhere in the file. Remove the now-redundant import from
_load_config().Fixes #5993