fix(install): create ~/.hermes before moving Node.js directory#53
Merged
Conversation
sudo-yf
pushed a commit
to sudo-yf/hermes-agent
that referenced
this pull request
Apr 5, 2026
fix(ci): Docker tag extraction for 2-part versions (v0.29)
sudo-yf
pushed a commit
to sudo-yf/hermes-agent
that referenced
this pull request
Apr 5, 2026
Use v(\d+\.\d+(?:\.\d+)?) instead of v(.*) to only match real version numbers (v0.29, v0.29.1), not arbitrary strings. Keep latest unconditional since all tag pushes are releases. Based on review of PR NousResearch#52 approach vs NousResearch#53. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
fix(install): create ~/.hermes before moving Node.js directory
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
fix(install): create ~/.hermes before moving Node.js directory
This was referenced May 31, 2026
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
fix(install): create ~/.hermes before moving Node.js directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #50
When Node.js is not installed on the system,
install_node()attempts to move the extracted tarball to~/.hermes/node/. However,~/.hermesis only created later inmain()bycopy_config_templates(), causing the following error:Add
mkdir -p "$HERMES_HOME"ininstall_node()before themvcall, so the destination directory always exists regardless of execution order.