Skip to content

fix(hindsight): overhaul hindsight memory plugin and memory setup wizard#5094

Merged
teknium1 merged 1 commit into
mainfrom
salvage/hindsight-5044
Apr 4, 2026
Merged

fix(hindsight): overhaul hindsight memory plugin and memory setup wizard#5094
teknium1 merged 1 commit into
mainfrom
salvage/hindsight-5044

Conversation

@teknium1

@teknium1 teknium1 commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Salvage of PR #5044 by @cdbartholomew — selective cherry-pick of the substantive hindsight memory plugin and setup wizard changes onto current main.

What changed

Hindsight plugin overhaul (plugins/memory/hindsight/__init__.py):

  • Dedicated asyncio event loop for async calls (fixes aiohttp session leaks)
  • Client caching (reuse instead of creating per-call)
  • Local mode daemon management with config change detection and auto-restart
  • Memory mode support (hybrid/context/tools) and prefetch method (recall/reflect)
  • Proper shutdown with event loop and client cleanup
  • Disable HindsightEmbedded.__del__ to avoid GC loop errors
  • Update API URLs (appui.hindsight.vectorize.io, api_urlbase_url)

Memory setup wizard (hermes_cli/memory_setup.py):

  • Conditional field display (when clause) — show/hide fields based on mode
  • Dynamic defaults (default_from) — model auto-defaults per provider
  • Switch dependency install from pip to uv (correct for uv-based venvs)
  • Add hindsight-all import mapping

Tests & docs:

  • 12 new tests for dispatch routing and setup field filtering
  • plugin.yaml: add hindsight-all dependency
  • README overhaul with full config documentation

What was dropped

The original PR was 4 commits behind main and silently reverted:

All non-hindsight changes were dropped. Only 5 files changed.

Test results

  • 5728 tests passing, 14 failures (all pre-existing on main)
  • 55/55 memory provider tests pass (including 12 new)

Co-authored-by: Chris Bartholomew chris.bartholomew@vectorize.io

- Dedicated asyncio event loop for Hindsight async calls (fixes aiohttp session leaks)
- Client caching (reuse instead of creating per-call)
- Local mode daemon management with config change detection and auto-restart
- Memory mode support (hybrid/context/tools) and prefetch method (recall/reflect)
- Proper shutdown with event loop and client cleanup
- Disable HindsightEmbedded.__del__ to avoid GC loop errors
- Update API URLs (app -> ui.hindsight.vectorize.io, api_url -> base_url)
- Setup wizard: conditional fields (when clause), dynamic defaults (default_from)
- Switch dependency install from pip to uv (correct for uv-based venvs)
- Add hindsight-all to plugin.yaml and import mapping
- 12 new tests for dispatch routing and setup field filtering

Original PR #5044 by cdbartholomew.
@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Install hook files modified

These files can execute code during package installation or interpreter startup.

Files:

hermes_cli/memory_setup.py

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@teknium1 teknium1 merged commit 28e1e21 into main Apr 4, 2026
5 of 6 checks passed
benfrank241 added a commit to vectorize-io/hindsight that referenced this pull request Apr 6, 2026
Reflects changes from NousResearch/hermes-agent#5094:
- Replace pip install quick start with hermes memory setup wizard
- Update config path to ~/.hermes/hindsight/config.json with flat snake_case keys
- Add memory_mode (hybrid/context/tools) and prefetch_method (recall/reflect)
- Add LLM provider config section for local mode with all 7 providers and default models
- Add HINDSIGHT_MODE, HINDSIGHT_LLM_API_KEY, HINDSIGHT_API_URL env vars
- Update local daemon section with auto-start behavior and log paths
- Fix URL: app.hindsight.vectorize.io -> ui.hindsight.vectorize.io
- Note tools only registered in hybrid/tools modes
benfrank241 added a commit to vectorize-io/hindsight that referenced this pull request Apr 6, 2026
Reflects changes from NousResearch/hermes-agent#5094:
- Replace pip install quick start with hermes memory setup wizard
- Update config path to ~/.hermes/hindsight/config.json with flat snake_case keys
- Add memory_mode (hybrid/context/tools) and prefetch_method (recall/reflect)
- Add LLM provider config section for local mode with all 7 providers and default models
- Add HINDSIGHT_MODE, HINDSIGHT_LLM_API_KEY, HINDSIGHT_API_URL env vars
- Update local daemon section with auto-start behavior and log paths
- Fix URL: app.hindsight.vectorize.io -> ui.hindsight.vectorize.io
- Note tools only registered in hybrid/tools modes
benfrank241 added a commit to vectorize-io/hindsight that referenced this pull request Apr 6, 2026
Reflects changes from NousResearch/hermes-agent#5094:
- Replace pip install quick start with hermes memory setup wizard
- Update config path to ~/.hermes/hindsight/config.json with flat snake_case keys
- Add memory_mode (hybrid/context/tools) and prefetch_method (recall/reflect)
- Add LLM provider config section for local mode with all 7 providers and default models
- Add HINDSIGHT_MODE, HINDSIGHT_LLM_API_KEY, HINDSIGHT_API_URL env vars
- Update local daemon section with auto-start behavior and log paths
- Fix URL: app.hindsight.vectorize.io -> ui.hindsight.vectorize.io
- Note tools only registered in hybrid/tools modes
benfrank241 added a commit to vectorize-io/hindsight that referenced this pull request Apr 6, 2026
Reflects changes from NousResearch/hermes-agent#5094:
- Replace pip install quick start with hermes memory setup wizard
- Update config path to ~/.hermes/hindsight/config.json with flat snake_case keys
- Add memory_mode (hybrid/context/tools) and prefetch_method (recall/reflect)
- Add LLM provider config section for local mode with all 7 providers and default models
- Add HINDSIGHT_MODE, HINDSIGHT_LLM_API_KEY, HINDSIGHT_API_URL env vars
- Update local daemon section with auto-start behavior and log paths
- Fix URL: app.hindsight.vectorize.io -> ui.hindsight.vectorize.io
- Note tools only registered in hybrid/tools modes
nicoloboschi added a commit to vectorize-io/hindsight that referenced this pull request Apr 8, 2026
…mory provider

Hermes Agent now ships with a native Hindsight memory provider (NousResearch/hermes-agent#5094),
making our pip-installable hindsight-hermes package redundant.

Removes:
- hindsight-integrations/hermes/ (source, tests, config)
- CI job, release script entry, changelog generator references
- Cookbook page and pip package changelog (referenced deleted code)

Keeps:
- Integration docs (updated by #881 for native provider)
- Blog posts (historical, already have deprecation notices)
- Sidebar/banner entries (still valid for native integration)
nicoloboschi added a commit to vectorize-io/hindsight that referenced this pull request Apr 8, 2026
…mory provider

Hermes Agent now ships with a native Hindsight memory provider (NousResearch/hermes-agent#5094),
making our pip-installable hindsight-hermes package redundant.

Removes:
- hindsight-integrations/hermes/ (source, tests, config)
- CI job, release script entry, changelog generator references
- Cookbook page and pip package changelog (referenced deleted code)

Keeps:
- Integration docs (updated by #881 for native provider)
- Blog posts (historical, already have deprecation notices)
- Sidebar/banner entries (still valid for native integration)
nicoloboschi added a commit to vectorize-io/hindsight that referenced this pull request Apr 8, 2026
* chore: drop hindsight-hermes integration in favor of native Hermes memory provider

Hermes Agent now ships with a native Hindsight memory provider (NousResearch/hermes-agent#5094),
making our pip-installable hindsight-hermes package redundant.

Removes:
- hindsight-integrations/hermes/ (source, tests, config)
- CI job, release script entry, changelog generator references
- Cookbook page and pip package changelog (referenced deleted code)

Keeps:
- Integration docs (updated by #881 for native provider)
- Blog posts (historical, already have deprecation notices)
- Sidebar/banner entries (still valid for native integration)

* fix(docs): remove broken cookbook link to deleted hermes-memory page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants