fix(api-server): pass fallback_model to AIAgent#4976
Closed
bugkill3r wants to merge 1 commit into
Closed
Conversation
The API server platform never passed fallback_model to AIAgent(), so the fallback provider chain was always empty for requests through the OpenAI-compatible endpoint. Load it via GatewayApp._load_fallback_model() to match the behavior of Telegram/Discord/Slack platforms.
Contributor
|
Merged via PR #5288 (consolidated bugfix salvage). Your commit(s) were cherry-picked onto current main with your authorship preserved in git log. Thanks @bugkill3r for the fix! |
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 28, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
- Fix GatewayApp → GatewayRunner import in api_server.py (PR NousResearch#4976) - Update launchd test assertions for new bootstrap/bootout/kickstart commands (PR NousResearch#4892) - Add nonlocal message declaration in run_sync() to fix UnboundLocalError (pre-existing scoping bug)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fallback_modeltoAIAgent(), so the fallback provider chain was always empty for OpenAI-compatible API requestsGatewayApp._load_fallback_model()to match Telegram/Discord/Slack platformsTest plan
fallback_providersin config.yaml