fix(openviking): correct API endpoint paths, response parsing, and auth headers#4742
Closed
catbusconductor wants to merge 1 commit into
Closed
fix(openviking): correct API endpoint paths, response parsing, and auth headers#4742catbusconductor wants to merge 1 commit into
catbusconductor wants to merge 1 commit into
Conversation
…th headers Fixes NousResearch#4740 - Change viking_browse from POST /api/v1/browse to GET /api/v1/fs/{ls,tree,stat} - Change viking_read from POST /api/v1/read to GET /api/v1/content/{read,abstract,overview} - Fix response parsing: API returns lists (not dicts with children key), uses camelCase (isDir not is_dir), content endpoints return strings directly - Add X-OpenViking-Account and X-OpenViking-User headers for trusted auth mode - Propagate account/user params to background thread client instances
zebster-cmd
added a commit
to zebster-cmd/hermes-agent
that referenced
this pull request
Apr 3, 2026
…OpenAPI spec Fixes NousResearch#4740 Validated all endpoints against a running OpenViking server's /openapi.json spec. This supersedes NousResearch#4742 with additional corrections. Endpoint corrections: - viking_browse: POST /api/v1/browse -> GET /api/v1/fs/{ls,tree,stat}?uri= - viking_read: POST /api/v1/read -> GET /api/v1/content/{read,abstract,overview}?uri= - viking_search: POST /api/v1/search/find (unchanged, was already correct) - viking_add_resource: POST /api/v1/resources (not /resources/add) - Search scope uses target_uri param, limit uses limit param Response parsing fixes: - fs endpoints return lists, not dicts with 'children' key - camelCase fields: isDir (not is_dir), rel_path (not name) - content endpoints return strings directly in result field - browse includes abstract field for agent output mode Auth additions: - X-OpenViking-Account and X-OpenViking-User headers for trusted auth mode - OPENVIKING_ACCOUNT / OPENVIKING_USER env vars with config schema entries - _make_client() helper propagates auth to all background thread clients Co-authored-by: catbusconductor <120737729+catbusconductor@users.noreply.github.com>
|
Hey @catbusconductor — nice catch on the endpoint paths. We validated your findings against a running OpenViking server's We found one additional issue your PR doesn't cover:
We also added:
We've opened #4743 which supersedes this with those additional fixes. Co-authored you since this builds directly on your work. Let us know if you'd prefer we update this PR instead. |
19 tasks
teknium1
pushed a commit
that referenced
this pull request
Apr 4, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR #4742 by catbusconductor. Auth header changes dropped
(already on main via #4825).
teknium1
pushed a commit
that referenced
this pull request
Apr 4, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR #4742 by catbusconductor. Auth header changes dropped
(already on main via #4825).
naoironman-hue
pushed a commit
to naoironman-hue/hermes-agent
that referenced
this pull request
Apr 5, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
This was referenced Apr 6, 2026
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
zebster-cmd
added a commit
to zebster-cmd/hermes-agent
that referenced
this pull request
Apr 18, 2026
…OpenAPI spec Validated all endpoints against running OpenViking server /openapi.json. Incorporates fixes from upstream PR NousResearch#4742 plus additional corrections. Endpoint corrections: - POST /api/v1/browse -> GET /api/v1/fs/{ls,tree,stat}?uri= - POST /api/v1/read -> GET /api/v1/content/{read,abstract,overview}?uri= - POST /api/v1/search/find (was correct, our earlier fix wrongly changed it) - POST /api/v1/resources (not /resources/add) - target_uri param restored (not scope) - limit param (not top_k) Response parsing fixes: - fs endpoints return lists, not dicts with 'children' key - camelCase fields: isDir not is_dir, rel_path not name - content endpoints return strings directly in result Auth additions (PR NousResearch#4742): - X-OpenViking-Account and X-OpenViking-User headers for trusted auth mode - OPENVIKING_ACCOUNT / OPENVIKING_USER env vars + config schema - _make_client() helper propagates auth to background thread clients
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 28, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
- Browse: POST /api/v1/browse → GET /api/v1/fs/{ls,tree,stat}
- Read: POST /api/v1/read[/abstract] → GET /api/v1/content/{read,abstract,overview}
- System prompt: result.get('children') → len(result) (API returns list)
- Content: result.get('content') → result is a plain string
- Browse: result['entries'] → result is the list; is_dir → isDir (camelCase)
- Browse: add rel_path and abstract fields to entry output
Based on PR NousResearch#4742 by catbusconductor. Auth header changes dropped
(already on main via NousResearch#4825).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4740
viking_browseusedPOST /api/v1/browseandviking_readusedPOST /api/v1/read— neither exists on the OpenViking server. Corrected toGET /api/v1/fs/{ls,tree,stat}andGET /api/v1/content/{read,abstract,overview}respectively.childrenkey), uses camelCase (isDirnotis_dir), and content endpoints return strings directly (not{"content": ...}).X-OpenViking-AccountandX-OpenViking-Userheaders to_VikingClientfor trusted auth mode, sourced fromOPENVIKING_ACCOUNTandOPENVIKING_USERenv vars.Test plan
auth_mode: trustedand verifyviking_browse viking://returns directory listingviking_readat all three levels (abstract, overview, full) returns contentOPENVIKING_ACCOUNT/OPENVIKING_USERenv vars are not set (defaults to "default")🤖 Generated with Claude Code