fix(slack): treat group DMs (mpim) like DMs + reaction guard#4633
Closed
gunpowder-client-vm wants to merge 1 commit into
Closed
fix(slack): treat group DMs (mpim) like DMs + reaction guard#4633gunpowder-client-vm wants to merge 1 commit into
gunpowder-client-vm wants to merge 1 commit into
Conversation
- is_dm now includes 'mpim' channel type so group DMs don't require @mentions and use continuous DM-style sessions - Reactions (👀 → ✅) are only added when the bot is actually processing a message (@mention or DM), preventing spurious reactions to casual channel messages in observe/listen-all mode
teknium1
pushed a commit
that referenced
this pull request
Apr 9, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR #4633 by gunpowder-client-vm, adapted to current main.
teknium1
pushed a commit
that referenced
this pull request
Apr 9, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR #4633 by gunpowder-client-vm, adapted to current main.
Contributor
|
Merged via PR #6809 as part of a consolidated Slack adapter improvement. Your contribution was adapted to current main. Your authorship is preserved in git history. Thank you @gunpowder-client-vm for your work on this! |
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 28, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
- Treat mpim (multi-party IM / group DM) channels as DMs — no @mention required, continuous session like 1:1 DMs - Only add 👀/✅ reactions when bot is directly addressed (DM or @mention). In listen-all channels (require_mention=false) reacting to every message would be noisy. Based on PR NousResearch#4633 by gunpowder-client-vm, adapted to current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_dmnow includesmpimchannel type so group DMs (multi-party IMs) don't require @mentions and use continuous DM-style sessions, matching the behavior users expect from group private conversations._should_reactflag — reactions only fire when the bot is actually processing a message (DM or @mention). This prevents spurious reactions to every casual message in channels where the bot is observing but not responding.Changes
gateway/platforms/slack.py:is_dm = channel_type in ("im", "mpim")— includempimalongsideim_should_reactguard wraps both_add_reaction/_remove_reactioncalls