Skip to content

fix: correct KawaiiSpinner file location in AGENTS.md#450

Closed
utkucankaraca1925 wants to merge 1 commit into
NousResearch:mainfrom
utkucankaraca1925:main
Closed

fix: correct KawaiiSpinner file location in AGENTS.md#450
utkucankaraca1925 wants to merge 1 commit into
NousResearch:mainfrom
utkucankaraca1925:main

Conversation

@utkucankaraca1925

Copy link
Copy Markdown

KawaiiSpinner is located in agent/display.py, not run_agent.py.

What does this PR do?

AGENTS.md incorrectly states that KawaiiSpinner is in run_agent.py.
It is actually in agent/display.py.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • AGENTS.md: corrected KawaiiSpinner file path from run_agent.py to agent/display.py

How to Test

  1. Open AGENTS.md
  2. Search for KawaiiSpinner
  3. Confirm it now points to agent/display.py

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

KawaiiSpinner is located in agent/display.py, not run_agent.py.
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for catching this! The fix has already been applied in a previous update to AGENTS.md — the KawaiiSpinner reference now correctly points to agent/display.py in our current version. Closing as already resolved, but appreciate the contribution! 🙏

@teknium1 teknium1 closed this Mar 10, 2026
rafe-walker added a commit to rafe-walker/kora that referenced this pull request May 24, 2026
…ndation + kora-runtime first pip package (#209)

Two new pip-installable packages under packages/, extracted from the
in-tree code with full backward-compat shims:

* packages/isokron-client/ — 20 substrate-functional modules lifted
  from plugins/memory/isokron/ (non-provider files only). Pure library
  with zero Kora / Hermes coupling at import time. ANY Hermes-based
  agent can `pip install isokron-client` to gain IsoKron substrate
  primitives: events / reads / control / scratchpad / policy /
  constitution / capability / sea_tickets. README §"BYOA usage
  example" shows a non-Kora custom plugin consuming the library.
  5/5 dry-run wheel-install smoke tests pass in a clean venv.

* packages/kora-runtime/ — 28 modules (7 sub-plugins + orchestrator)
  lifted from kora_cli/reasoning/kora_hermes_plugin/. Declares
  `isokron-client` as a PyPI dep; Hermes is source-only per the
  2026-05-25 operator decision (README documents `git clone
  hermes-agent && pip install -e . && pip install kora-runtime`).
  Entry point `hermes_agent.plugins.kora = kora_runtime:register`
  validated via `importlib.metadata.entry_points()` after dry-run
  install. 5/5 dry-run wheel-install smoke tests + 142/151 in-tree
  tests pass (8 pre-existing Marvin data-dir failures unrelated;
  0 regressions from extraction).

Back-compat shims at plugins/memory/isokron/__init__.py and
kora_cli/reasoning/kora_hermes_plugin/__init__.py do sys.path
bootstrap (mirrors the plugins/marvin/__init__.py POC pattern from
#204) plus sys.modules aliasing of the moved sub-modules. Existing
in-tree imports of the form `from plugins.memory.isokron.X import Y`
and `from kora_cli.reasoning.kora_hermes_plugin.X import Y` continue
working unchanged — no per-file shims, no caller sweep across the
rest of the Kora tree.

§4 STOP-ASK A.1 resolved by operator decision: (B) tight-scoped
extraction. provider.py + active_provider.py + sea_ticket_poller*
stay in plugins/memory/isokron/ as the Hermes-plugin half importing
from isokron-client. kora_cli/clients/kora_control_writer.py +
kora_cli/audit/jsonl_sink.py deferred to Phase 1b (operator task
NousResearch#450). API surface uses real grep'd names (events / reads / control /
scratchpad / policy / constitution / capability / sea_tickets), not
the bucket's audit/conversation/workspace strawman that didn't map
to what was in the tree.

Companion kora-docs PR amends AUDIT.md from 4-package to 5-package
split + closes §7.1 (Hermes source-only) + §7.2 (isokron-client
separate package).

Co-authored-by: CC#3 Kora Runtime <kora-pm@stormhavenenterprises.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants