fix: correct KawaiiSpinner file location in AGENTS.md#450
Closed
utkucankaraca1925 wants to merge 1 commit into
Closed
fix: correct KawaiiSpinner file location in AGENTS.md#450utkucankaraca1925 wants to merge 1 commit into
utkucankaraca1925 wants to merge 1 commit into
Conversation
KawaiiSpinner is located in agent/display.py, not run_agent.py.
Contributor
|
Thanks for catching this! The fix has already been applied in a previous update to AGENTS.md — the KawaiiSpinner reference now correctly points to |
7 tasks
rafe-walker
added a commit
to rafe-walker/kora
that referenced
this pull request
May 24, 2026
…ndation + kora-runtime first pip package (#209) Two new pip-installable packages under packages/, extracted from the in-tree code with full backward-compat shims: * packages/isokron-client/ — 20 substrate-functional modules lifted from plugins/memory/isokron/ (non-provider files only). Pure library with zero Kora / Hermes coupling at import time. ANY Hermes-based agent can `pip install isokron-client` to gain IsoKron substrate primitives: events / reads / control / scratchpad / policy / constitution / capability / sea_tickets. README §"BYOA usage example" shows a non-Kora custom plugin consuming the library. 5/5 dry-run wheel-install smoke tests pass in a clean venv. * packages/kora-runtime/ — 28 modules (7 sub-plugins + orchestrator) lifted from kora_cli/reasoning/kora_hermes_plugin/. Declares `isokron-client` as a PyPI dep; Hermes is source-only per the 2026-05-25 operator decision (README documents `git clone hermes-agent && pip install -e . && pip install kora-runtime`). Entry point `hermes_agent.plugins.kora = kora_runtime:register` validated via `importlib.metadata.entry_points()` after dry-run install. 5/5 dry-run wheel-install smoke tests + 142/151 in-tree tests pass (8 pre-existing Marvin data-dir failures unrelated; 0 regressions from extraction). Back-compat shims at plugins/memory/isokron/__init__.py and kora_cli/reasoning/kora_hermes_plugin/__init__.py do sys.path bootstrap (mirrors the plugins/marvin/__init__.py POC pattern from #204) plus sys.modules aliasing of the moved sub-modules. Existing in-tree imports of the form `from plugins.memory.isokron.X import Y` and `from kora_cli.reasoning.kora_hermes_plugin.X import Y` continue working unchanged — no per-file shims, no caller sweep across the rest of the Kora tree. §4 STOP-ASK A.1 resolved by operator decision: (B) tight-scoped extraction. provider.py + active_provider.py + sea_ticket_poller* stay in plugins/memory/isokron/ as the Hermes-plugin half importing from isokron-client. kora_cli/clients/kora_control_writer.py + kora_cli/audit/jsonl_sink.py deferred to Phase 1b (operator task NousResearch#450). API surface uses real grep'd names (events / reads / control / scratchpad / policy / constitution / capability / sea_tickets), not the bucket's audit/conversation/workspace strawman that didn't map to what was in the tree. Companion kora-docs PR amends AUDIT.md from 4-package to 5-package split + closes §7.1 (Hermes source-only) + §7.2 (isokron-client separate package). Co-authored-by: CC#3 Kora Runtime <kora-pm@stormhavenenterprises.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KawaiiSpinner is located in agent/display.py, not run_agent.py.
What does this PR do?
AGENTS.md incorrectly states that KawaiiSpinner is in run_agent.py.
It is actually in agent/display.py.
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs