fix: add missing re.DOTALL flag to DeepSeek V3 tool call parser#444
Merged
teknium1 merged 1 commit intoMar 6, 2026
Merged
Conversation
1 task
teknium1
added a commit
that referenced
this pull request
Mar 6, 2026
The V3.1 parser had the same issue — .*? without re.DOTALL fails to match multi-line JSON arguments. Found during review of PR #444.
Contributor
|
Merged in commit 936fda3 🎉 Thanks @PercyDikec! Also found the same bug in |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…k V3 tool call parser Authored by PercyDikec. Fixes NousResearch#443. Without re.DOTALL, the regex .* doesn't match newlines, so multi-line JSON arguments (the normal case) silently fail to parse. Every other parser in the codebase that matches across lines already uses re.DOTALL.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
The V3.1 parser had the same issue — .*? without re.DOTALL fails to match multi-line JSON arguments. Found during review of PR NousResearch#444.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…k V3 tool call parser Authored by PercyDikec. Fixes NousResearch#443. Without re.DOTALL, the regex .* doesn't match newlines, so multi-line JSON arguments (the normal case) silently fail to parse. Every other parser in the codebase that matches across lines already uses re.DOTALL.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
The V3.1 parser had the same issue — .*? without re.DOTALL fails to match multi-line JSON arguments. Found during review of PR NousResearch#444.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…k V3 tool call parser Authored by PercyDikec. Fixes NousResearch#443. Without re.DOTALL, the regex .* doesn't match newlines, so multi-line JSON arguments (the normal case) silently fail to parse. Every other parser in the codebase that matches across lines already uses re.DOTALL.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
The V3.1 parser had the same issue — .*? without re.DOTALL fails to match multi-line JSON arguments. Found during review of PR NousResearch#444.
10 tasks
rafe-walker
added a commit
to rafe-walker/kora
that referenced
this pull request
May 24, 2026
…lti-tenant cockpit chrome + wizard resume (#207) Deliverable A — tenant-picker cockpit chrome: * /api/tenants/list BE endpoint (wraps list_cost_holder_tenants; always default-first, synthesizes default when registry is named-only) * useActiveTenant() hook with URL ?tenant= → localStorage → "default" resolution; cross-tab + in-tab event-driven re-render * TenantPicker dropdown in sidebar header chrome; renders nothing when <2 tenants observed (A.6 single-tenant degradation) * /api/cost-state extended with optional ?tenant_id= → per-tenant holder lookup; CostStatePage + DashboardPage CostCardBody read snap.cost_ladder_by_tenant[activeTenant] when non-default * Audit + promotion pages forward ?tenant_id= (Probe + Alert Investigations, Email Intent + Outbound + Autofix logs, Kora Actions, PromotionReviewPage); BE-side filter lands with CC#1 NousResearch#444 — FE wires the param + graceful fallback today * Drift-guard pins: TENANT_ID_QUERY_PARAM_NAME (BE) ↔ TENANT_ID_QUERY_PARAM (FE) cross-stack test in tests/test_tenants_endpoint.py + storage-key + default-id pins Deliverable B — wizard sessionStorage resume: * sessionStorage["kora_wizard_state"] persists step + non-cred config on every change * On mount past step 0, render Resume? prompt (yes restores + jumps to saved step; no clears + fresh start) * Credentials NEVER stored (anthropicApiKey, substrateServiceRoleKey, slackBotToken stripped before persist); validation results also reset on resume so the operator re-validates re-entered creds * Cleared on wizard complete + skip (terminal states) Note: PM bucket attributed cost_ladder consumption to CostTelemetryPage; in HEAD the cost_ladder block is consumed by DashboardPage CostCardBody + CostStatePage (CostTelemetryPage reads per-route /api/cost_telemetry, not per-tenant cost_ladder). A.4 applied to the actual cost_ladder consumers. Co-authored-by: CC#2 Kora Web <kora-pm@stormhavenenterprises.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…k V3 tool call parser Authored by PercyDikec. Fixes NousResearch#443. Without re.DOTALL, the regex .* doesn't match newlines, so multi-line JSON arguments (the normal case) silently fail to parse. Every other parser in the codebase that matches across lines already uses re.DOTALL.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
The V3.1 parser had the same issue — .*? without re.DOTALL fails to match multi-line JSON arguments. Found during review of PR NousResearch#444.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The DeepSeek V3 tool call parser regex was missing
re.DOTALL, so.*couldn't match newlines in thefunction_argumentscapture group. Since tool call JSON arguments are almost always multi-line, the parser silently failed on most real tool calls and returned raw text instead.Every other parser in the codebase (hermes, mistral, glm45, glm47, qwen3_coder, kimi_k2, longcat) already uses
re.DOTALLfor their patterns.Related Issue
Fixes #443
Type of Change
Changes Made
environments/tool_call_parsers/deepseek_v3_parser.py: Addedre.DOTALLflag toPATTERNregex compilationHow to Test
environments/tool_call_parsers/- all usere.DOTALL{"query": "hello"}{ "query": "hello", "limit": 5 }Checklist
Code
Documentation & Housekeeping