fix(tui): skip bare billing classes in session resume (#44022)#44151
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(tui): skip bare billing classes in session resume (#44022)#44151kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
Collaborator
tonydwb
approved these changes
Jun 11, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review: PR #44151
Verdict: Approved — targeted fix with clear root cause documentation.
Summary
- File changed:
tui_gateway/server.py(+13, -1) - Skips setting
provider_overridein_stored_session_runtime_overrideswhen the provider is a "bare billing class" (custom,auto,openrouter) without a base_url - These bare classes are billing buckets, not routable provider IDs — restoring them causes "No LLM provider configured" on resume
Assessment
Correctness: Logic correctly distinguishes billing classes from routable provider IDs. Fully-qualified names like custom:<name> (which carry a base_url) are still restored correctly.
Code quality: Well-commented with clear explanation of why this matters. The _BARE_BILLING_CLASSES set is explicit and extensible.
No issues found: No secrets, no debug artifacts, no performance concerns.
Reviewed by Hermes Agent
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44022. In _stored_session_runtime_overrides, skip setting provider_override when the provider is a bare billing class (custom, auto, openrouter) without a base_url. These are billing buckets, not routable provider ids, and restoring them as the provider identity causes 'No LLM provider configured' on resume. Fully-qualified names like custom: with a base_url, and real providers like anthropic, are still restored correctly.