fix(desktop): recover from a stale IME composition flag that silently blocks all sends#44149
Open
AIalliAI wants to merge 1 commit into
Open
fix(desktop): recover from a stale IME composition flag that silently blocks all sends#44149AIalliAI wants to merge 1 commit into
AIalliAI wants to merge 1 commit into
Conversation
…he composer A missed compositionend (focus jump, input-source switch, programmatic DOM swap mid-preedit) left composingRef stuck true, and the stuck flag silently swallowed every Enter in handleEditorKeyDown and every Send-button submit via the form onSubmit guard — no error, no RPC, until the composer remounted. For CJK IME users (where even ASCII typing runs through composition) this read as "Enter has no effect; messages cannot be sent", degrading composer instance by composer instance. Recover in two places, both grounded in invariants Chromium guarantees: - keydown: every keydown during a genuine composition carries isComposing=true, so when the native flag says we're not composing, clear the stale ref before the guard reads it. - blur: a composition never survives focus loss, so clear the flag unconditionally — this is what unblocks the Send button path, which has no native composition flag to consult. The genuine-IME protection (NousResearch#37483 class) is untouched: Enter with isComposing=true is still swallowed. Fixes NousResearch#44135 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
12 tasks
questionjie-max
pushed a commit
to questionjie-max/hermes-agent
that referenced
this pull request
Jun 11, 2026
…osition Three remaining fixes for CJK IME in the desktop composer: 1. handleEditorInput now calls flushEditorToDraft() — it was left as a no-op after the composingRef guard was removed (NousResearch#39614 fix), meaning the Send button never appeared during IME typing because draft state was never synced on input events. 2. onCompositionEnd auto-submits when imeEnterRef is set — Enter during IME composition is consumed by the IME to commit the preedit, so submitDraft() never fires. Detect this and auto-submit for one-Enter CJK send instead of requiring a second Enter. 3. onBlur resets composingRef unconditionally — prevents a stale composition flag from permanently blocking the Send button's form-submit guard (NousResearch#44135). Closes NousResearch#44135 Complements NousResearch#44149
questionjie-max
added a commit
to questionjie-max/hermes-agent
that referenced
this pull request
Jun 11, 2026
…osition Three remaining fixes for CJK IME in the desktop composer: 1. handleEditorInput now calls flushEditorToDraft() — it was left as a no-op after the composingRef guard was removed (NousResearch#39614), meaning the Send button never appeared during IME typing. 2. onCompositionEnd auto-submits when imeEnterRef is set — Enter during IME composition is consumed by the IME to commit the preedit, so submitDraft() never fires. Detect this and auto-submit for one-Enter CJK send. 3. onBlur resets composingRef unconditionally — prevents a stale composition flag from permanently blocking the Send button (NousResearch#44135). Closes NousResearch#44135 Complements NousResearch#44149
Contributor
|
✅ Verification — stale IME composition flag recovery is well-designed Checked:
The approach is defensive without being over-eager — it only clears the flag when the native event explicitly says composition is not active. LGTM. |
questionjie-max
pushed a commit
to questionjie-max/hermes-agent
that referenced
this pull request
Jun 11, 2026
…osition Two interacting problems prevented CJK IME users from sending messages via Enter in the desktop composer: 1. handleEditorInput skipped draft updates when composingRef was true, so the React draft state stayed empty during IME typing. This meant hasComposerPayload was always false — the Send button never appeared, and the submit path had nothing to send. 2. (Upstream already fixed) submitDraft() now uses draftRef.current Fixes: - Remove the composingRef guard from handleEditorInput. Draft now updates during IME composition so the Send button appears as soon as text is in the editor. The Enter guard in handleEditorKeyDown still blocks premature submission via event.nativeEvent.isComposing. - Add imeEnterRef to track Enter during IME composition. On compositionend, if set, the committed text is synced from the DOM into state and submitDraft() is scheduled — CJK users get one-Enter send instead of needing a second Enter. - Self-heal stale composition flag: clear composingRef on keydown when nativeEvent.isComposing is false, and reset on blur unconditionally (upstream fix from NousResearch#44149 applied locally). Closes NousResearch#44135
tonydwb
approved these changes
Jun 11, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review: PR #44149
Verdict: Approved — well-reasoned defensive fix for stale IME composition flag.
Summary
Files changed: apps/desktop/src/app/chat/composer/index.tsx (+17, -1), new test file (+129)
Adds recovery from a stale composingRef that silently blocks Enter and Send button when compositionend is missed (focus jumps, input-source switches, DOM mutations).
Assessment
Correctness: Two recovery points grounded in Chromium invariants: (1) keydown self-heal clears the flag when native isComposing says we're not composing; (2) blur unconditionally clears the flag. Both are safe — genuine IME composition is still protected.
No issues found.
Reviewed by Hermes Agent
Contributor
Author
|
Requesting maintainer review — this is ready to land from my side. Standalone fork CI is pending first-run approval here; the rollup branch in #44061 carrying this session's batch is fully green on upstream CI (all test shards, typecheck, e2e). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defensive fix for #44135 — Desktop composer Enter (and the Send button) silently doing nothing, with no error and no
session.create/prompt.submitever reaching the gateway.The composer guards submission behind
composingRef(set oncompositionstart, cleared oncompositionend) so that Enter confirming a CJK IME preedit doesn't split the message (#37483 class). But ifcompositionendis ever missed — focus jump, input-source switch, or a programmatic DOM mutation aborting the preedit — the flag wedgestrueand from then on every path out of the composer is silently swallowed:handleEditorKeyDownreturns before the Enter branch (composer/index.tsx)onSubmitguard blocks the Send button tooNo error surfaces, nothing hits the gateway, and the state persists until the composer instance remounts. For Chinese IME users even ASCII typing runs through composition (Pinyin ABC mode), so one wedge kills all sending — matching the reporter's "first new sessions, then everything" progression (pre-decoupling, composer instances differed per thread and degraded one by one as each was touched).
Fix
Two recovery points, each grounded in an invariant Chromium (Electron's only engine) guarantees:
nativeEvent.isComposing === true. If the ref says composing but the native flag says no, the ref is stale: clear it before the guard reads it.compositionendon blur). Clear the flag unconditionally on blur; this is what un-wedges the Send button path, which has no native composition flag to consult.Genuine IME protection is unchanged: Enter with
isComposing=trueis still swallowed, and the new test locks that in alongside the recovery behavior.Testing
enter-stale-ime-flag.test.tsx(harness-mirror style, same asenter-submit-dom-race.test.tsx): wedged-flag Enter recovery, genuine-composition swallow + post-compositionendsend, Send-button unblock after blur with a missedcompositionend.npx vitest run --environment jsdom src/app/chat/composer/— 7 files, 25 tests pass.tsc -bandeslintclean on touched files.Note for the reporter's setup: the bootstrap
install.shHTTP 404s in their log are a separate, expected fallback path (locally-built app stamped to an unpushed commit;bootstrap-runner.cjsfalls back to the installed checkout's script) and are not related to this bug.Fixes #44135
🤖 Generated with Claude Code