fix(desktop): scope thinking disclosure pending state#43197
Merged
OutThisLife merged 1 commit intoJun 10, 2026
Conversation
Contributor
Verification: clean — correct scoping fixThis PR correctly scopes the pending-running check in
LGTM — no issues found. |
wachoo
pushed a commit
to wachoo/hermes-agent
that referenced
this pull request
Jun 10, 2026
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Desktop thinking disclosure auto-open state so each reasoning disclosure only checks its own reasoning group for pending content.
Before this change,
ReasoningAccordionGroupscanned from the current group start through the rest of the assistant message. If a later thinking block was still running, older completed thinking blocks in the same message could be treated as pending and reopen automatically.This bounds the pending check to
startIndex..endIndex, matching the existing content check and the actual reasoning group rendered by that disclosure.Related Issue
Discord support thread: https://discord.com/channels/1053877538025386074/1514062044263874704
Type of Change
Changes Made
apps/desktop/src/components/assistant-ui/thread.tsx: boundpendingdetection forReasoningAccordionGroupto the current reasoning group.apps/desktop/src/components/assistant-ui/streaming.test.tsx: added a regression covering separated reasoning groups where the earlier completed group stays collapsed while a later group is running.How to Test
npm run test:ui --workspace apps/desktop -- src/components/assistant-ui/streaming.test.tsx -t "does not reopen an earlier completed thinking group".aria-expanded=false, second disclosurearia-expanded=true.Focused validation run locally:
npm run test:ui --workspace apps/desktop -- src/components/assistant-ui/streaming.test.tsx -t "does not reopen an earlier completed thinking group"Note: the full
streaming.test.tsxfile currently has an unrelated existing failure inrenders an incomplete streaming reasoning fenced code block as a code card, which also fails when run by itself in this checkout.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
User report shows Desktop
Client v0.16.0 (+21)andBackend v0.16.0 (+21)with prior thinking blocks expanded again after a later thinking block appears.