Skip to content

fix(models): keep curated Anthropic aliases (claude-fable-5) in /model picker#43103

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-692c9962
Jun 9, 2026
Merged

fix(models): keep curated Anthropic aliases (claude-fable-5) in /model picker#43103
teknium1 merged 1 commit into
mainfrom
hermes/hermes-692c9962

Conversation

@teknium1

@teknium1 teknium1 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

claude-fable-5 (and any newly-routed curated Anthropic alias) now stays in the /model picker even on a native Anthropic setup.

Root cause: provider_model_ids("anthropic") returned the live /v1/models dump verbatim when credentials were configured. Anthropic's API lags freshly-routed aliases — claude-fable-5 is reachable on Anthropic before the models endpoint enumerates it — so the curated entry dropped out of the picker.

Changes

  • hermes_cli/models.py: merge curated _PROVIDER_MODELS["anthropic"] with the live catalog — curated first, live-only models appended, deduped (case-insensitive). Live failure / no creds falls back to the curated list verbatim. Mirrors the existing OpenAI curated-merge philosophy.
  • tests/hermes_cli/test_anthropic_picker_curated.py: regression coverage — curated alias survives when live omits it, merge dedupes overlap and appends live-only, fallback when live unavailable.

Validation

Before After
Live omits claude-fable-5 dropped from picker surfaces (curated order, first)
Live overlaps curated n/a deduped, single entry
Live-only model n/a appended (discovery preserved)
No creds / live fails curated curated (unchanged)

tests/hermes_cli/test_anthropic_picker_curated.py — 3 passed. Sibling picker tests (-k "anthropic or provider_model") — 120 passed, no regressions.

Infographic

curated-model-aliases-survive-the-picker

The Anthropic picker returned the live /v1/models dump verbatim whenever
credentials were configured. Anthropic's API lags newly-routed curated
aliases (e.g. claude-fable-5, reachable on Anthropic before the models
endpoint enumerates it), so the curated entry vanished from the picker.

Merge curated _PROVIDER_MODELS["anthropic"] with the live catalog —
curated first, live-only appended, deduped — mirroring the OpenAI
curated-merge path. Live failure / no creds falls back to curated verbatim.
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-692c9962 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 10614 on HEAD, 10614 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5561 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@teknium1 teknium1 merged commit 57c6714 into main Jun 9, 2026
21 checks passed
@teknium1 teknium1 deleted the hermes/hermes-692c9962 branch June 9, 2026 21:45
wachoo pushed a commit to wachoo/hermes-agent that referenced this pull request Jun 10, 2026
…earch#43103)

The Anthropic picker returned the live /v1/models dump verbatim whenever
credentials were configured. Anthropic's API lags newly-routed curated
aliases (e.g. claude-fable-5, reachable on Anthropic before the models
endpoint enumerates it), so the curated entry vanished from the picker.

Merge curated _PROVIDER_MODELS["anthropic"] with the live catalog —
curated first, live-only appended, deduped — mirroring the OpenAI
curated-merge path. Live failure / no creds falls back to curated verbatim.
ziliangpeng pushed a commit to ziliangpeng/hermes-agent that referenced this pull request Jun 10, 2026
…earch#43103)

The Anthropic picker returned the live /v1/models dump verbatim whenever
credentials were configured. Anthropic's API lags newly-routed curated
aliases (e.g. claude-fable-5, reachable on Anthropic before the models
endpoint enumerates it), so the curated entry vanished from the picker.

Merge curated _PROVIDER_MODELS["anthropic"] with the live catalog —
curated first, live-only appended, deduped — mirroring the OpenAI
curated-merge path. Live failure / no creds falls back to curated verbatim.
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
…earch#43103)

The Anthropic picker returned the live /v1/models dump verbatim whenever
credentials were configured. Anthropic's API lags newly-routed curated
aliases (e.g. claude-fable-5, reachable on Anthropic before the models
endpoint enumerates it), so the curated entry vanished from the picker.

Merge curated _PROVIDER_MODELS["anthropic"] with the live catalog —
curated first, live-only appended, deduped — mirroring the OpenAI
curated-merge path. Live failure / no creds falls back to curated verbatim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant