fix(terminal): lazy-parse Docker env config#42733
Merged
benbarclay merged 1 commit intoJun 10, 2026
Merged
Conversation
14 tasks
This was referenced Jun 9, 2026
wachoo
pushed a commit
to wachoo/hermes-agent
that referenced
this pull request
Jun 10, 2026
Co-authored-by: BROCCOLO1D <279959838+BROCCOLO1D@users.noreply.github.com>
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
Co-authored-by: BROCCOLO1D <279959838+BROCCOLO1D@users.noreply.github.com>
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
Co-authored-by: BROCCOLO1D <279959838+BROCCOLO1D@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TERMINAL_DOCKER_VOLUMESerror for bad JSON.Why
TERMINAL_DOCKER_VOLUMES=Noneand similar malformed Docker-only env/config values were parsed eagerly inside terminal config loading, which could crash the defaultlocalbackend before Docker was ever used.Changes
TERMINAL_ENV=docker.Validation
python -m ruff check tools/terminal_tool.py tests/tools/test_terminal_tool.pypython -m pytest tests/tools/test_terminal_tool.py tests/tools/test_terminal_config_env_sync.py -o 'addopts=' -qScope
Focused terminal config parsing regression fix only.
Closes #42725