chore(gateway): drop HOMEASSISTANT from /update allowlist#40736
Merged
Conversation
Home Assistant is a bundled plugin now (#40709) and declares allow_update_command=True on its PlatformEntry. The registry fallback in _handle_update_command already covers it, so the frozenset entry is a redundant double-allow — same cleanup #40711 did for Discord and Mattermost. Adds a registry-fallback test mirroring the existing discord/mattermost cases.
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
…ch#40736) Home Assistant is a bundled plugin now (NousResearch#40709) and declares allow_update_command=True on its PlatformEntry. The registry fallback in _handle_update_command already covers it, so the frozenset entry is a redundant double-allow — same cleanup NousResearch#40711 did for Discord and Mattermost. Adds a registry-fallback test mirroring the existing discord/mattermost cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops
Platform.HOMEASSISTANTfrom the_UPDATE_ALLOWED_PLATFORMSfrozenset ingateway/run.py. Home Assistant is a bundled plugin now (#40709) and declaresallow_update_command=Trueon itsPlatformEntry; the registry fallback in_handle_update_commandalready covers it, so the frozenset entry is a redundant double-allow — the same cleanup #40711 did for Discord and Mattermost.Changes
gateway/run.py: removePlatform.HOMEASSISTANTfrom_UPDATE_ALLOWED_PLATFORMStests/gateway/test_update_command.py: addtest_allows_homeassistant_via_registry_fallback, mirroring the existing discord/mattermost cases — asserts HA is not in the frozenset, the registry entry hasallow_update_command=True, and/updateis not rejected by the gateValidation
homeassistantentry hasallow_update_command=TruePlatform.HOMEASSISTANTremoved; Discord/Mattermost already gone (#40711)test_update_command.py(+1 new fallback case)Follow-up to #40709 (HA → bundled plugin) and #40711 (Discord/Mattermost allowlist cleanup), which explicitly deferred HA until the migration landed.
Infographic