fix(tui): clean force-send of queued messages#40235
Merged
Merged
Conversation
Force-sending a queued message (double-empty-enter, or interrupt-mode submit) flipped busy→false optimistically, so the queue drain raced the still-unwinding turn: duplicate user bubble, a stray "queued: …" note, and the cancelled turn's "Operation interrupted…" reply leaking in. interruptTurn gains `keepBusy`: hold busy until the gateway's real settle edge (message.complete, suppressed while interrupted), which drains the queued message exactly once — desktop "send now" parity. The interrupt paths now queue + interrupt instead of optimistically sending.
Contributor
🔎 Lint report:
|
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
Force-sending a queued message (double-empty-enter, or interrupt-mode submit) flipped busy→false optimistically, so the queue drain raced the still-unwinding turn: duplicate user bubble, a stray "queued: …" note, and the cancelled turn's "Operation interrupted…" reply leaking in. interruptTurn gains `keepBusy`: hold busy until the gateway's real settle edge (message.complete, suppressed while interrupted), which drains the queued message exactly once — desktop "send now" parity. The interrupt paths now queue + interrupt instead of optimistically sending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Force-sending a queued TUI message (double-empty-enter, or interrupt-mode submit) was janky:
interruptTurnflippedbusy → falseoptimistically, so the queue drain raced the still-unwinding turn. That race produced a duplicate user bubble, a strayqueued: "…"note, and the cancelled turn'sOperation interrupted: waiting for model responsereply leaking into the transcript.turnController.interruptTurngains akeepBusyoption — holdbusyuntil the gateway's real settle edge (message.complete, suppressed whileinterrupted), so the queued message drains exactly once. Mirrors the desktop "send now" flow.handleBusyInput'interrupt' branch + thesubmitdouble-empty-enter force-send) now queue + interrupt instead of optimisticallysend-ing. Plain Stop (empty queue) is unchanged → settles toready.Result:
[old turn] → interrupted → one user bubble → new turn. Queue editing is untouched.Test plan
keepBusyinvariant test (createGatewayEventHandler.test.ts): busy held after interrupt; cancelled turn'sfinal_responsesuppressed; settle flips busy false.createGatewayEventHandler+useQueuesuites pass (58).queued:note / backend interrupt line.