fix(desktop): repair macOS updater helper#40217
Merged
OutThisLife merged 1 commit intoJun 6, 2026
Merged
Conversation
tonydwb
approved these changes
Jun 6, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Approved. Narrow macOS updater helper repair — well-scoped, no issues.
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Repairs the staged macOS updater helper before Hermes Desktop hands off an in-app update to it.
Desktop launches
~/.hermes/hermes-setup --update ...when a staged bootstrap installer exists. On affected macOS installs, Gatekeeper can reject that helper as damaged before it ever runs. The existing macOS relaunch repair handles the rebuiltHermes.appbundle, but the separately staged helper was copied intoHERMES_HOMEwithout any quarantine/signature repair.This adds best-effort macOS repair in both places that matter:
~/.hermes/hermes-setupThe repair clears quarantine and only ad-hoc signs the helper when
codesign --verifyfails, so a valid signed helper is not force-re-signed.Related Issue
N/A - observed in Discord support thread
1512387943531286718from a macOS Desktop update failure where the log showed Desktop launching~/.hermes/hermes-setup --update --branch main --target-app ..., and the screenshot showed macOS rejectinghermes-setupas damaged.Type of Change
Changes Made
apps/bootstrap-installer/src-tauri/src/paths.rs: repair the staged macOS helper after copying the installer intoHERMES_HOME.apps/desktop/electron/main.cjs: repair an existing staged macOS helper before Desktop spawns it for in-app update handoff.How to Test
~/.hermes/hermes-setupexists.Local validation performed:
node --check apps/desktop/electron/main.cjsgit diff --check -- apps/bootstrap-installer/src-tauri/src/paths.rs apps/desktop/electron/main.cjsNot run locally:
cargo fmt/rustfmt/ Rust compile checks: Rust tooling is not installed in this WSL environment.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Support evidence:
"hermes-setup" is damaged and can't be opened. You should move it to the Bin.~/.hermes/hermes-setup --update --branch main --target-app .../Hermes.app