Skip to content

fix(desktop): sync file attachments to remote workspace#38615

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/38464-remote-file-sync
Closed

fix(desktop): sync file attachments to remote workspace#38615
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/38464-remote-file-sync

Conversation

@LeonSGP43

@LeonSGP43 LeonSGP43 commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add a desktop file.attach gateway RPC that stages remote-only file attachments into the session workspace
  • sync file attachment refs before prompt.submit so remote gateway turns use workspace-relative @file: refs instead of local desktop paths
  • cover the backend staging path and desktop submit flow with targeted tests

Fixes #38464

Verification

  • uv run --frozen pytest tests/test_tui_gateway_server.py -k "file_attach or image_attach"
  • uv run --frozen ruff check tui_gateway/server.py tests/test_tui_gateway_server.py
  • npm run test:ui -- src/app/session/hooks/use-prompt-actions.test.tsx
  • npx eslint src/app/session/hooks/use-prompt-actions.ts src/app/session/hooks/use-prompt-actions.test.tsx src/app/types.ts src/store/updates.ts
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery tool/file File tools (read, write, patch, search) labels Jun 4, 2026
@teknium1 teknium1 mentioned this pull request Jun 9, 2026
Merged
teknium1 added a commit that referenced this pull request Jun 9, 2026
@teknium1 @LeonSGP43
feat(desktop+gateway): remote-gateway file attachments via file.attach
dbbd1d4 
@file: attachments now work when the desktop is connected to a remote
gateway. Previously a referenced file resolved to a client-disk path the
gateway couldn't see, so context_references rejected it with "path is
outside the allowed workspace" and the agent never saw the file.

Adds a file.attach RPC (sibling to the existing image.attach_bytes /
pdf.attach byte-upload pipeline): the desktop uploads the file bytes, the
gateway stages them into <workspace>/.hermes/desktop-attachments/ and
returns a workspace-relative @file: ref that resolves cleanly. Local mode
passes the path directly; a gateway-visible file outside the workspace is
copied in; an in-workspace file is referenced as-is with no copy.

Consolidates the file-sync design from #38615 (LeonSGP43) and the
host-file-staging idea from #33455 (Carry00), rebased onto the
image/PDF remote-media helpers already on main.

Co-authored-by: LeonSGP43 <cine.dreamer.one@gmail.com>
@teknium1

teknium1 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Merged via #42634 (commit dbbd1d4 on main). Your file-sync design — the file.attach RPC, workspace staging, and @file: ref rewrite — is the core of it, rebased onto current main (which had since picked up the image/PDF byte-upload helpers) and preserved with your authorship via a Co-authored-by trailer. One fix on top: the data-URL decoder now handles any mime type (the image-only decoder couldn't parse data:text/csv;...). Thanks for this — it closes the #1 friction point for remote desktop users.

@teknium1 teknium1 closed this Jun 9, 2026
a249169329-cpu pushed a commit to a249169329-cpu/hermes-agent that referenced this pull request Jun 9, 2026
@teknium1 @LeonSGP43 @hermes-agent
feat(desktop+gateway): remote-gateway file attachments via file.attach
6177280 
@file: attachments now work when the desktop is connected to a remote
gateway. Previously a referenced file resolved to a client-disk path the
gateway couldn't see, so context_references rejected it with "path is
outside the allowed workspace" and the agent never saw the file.

Adds a file.attach RPC (sibling to the existing image.attach_bytes /
pdf.attach byte-upload pipeline): the desktop uploads the file bytes, the
gateway stages them into <workspace>/.hermes/desktop-attachments/ and
returns a workspace-relative @file: ref that resolves cleanly. Local mode
passes the path directly; a gateway-visible file outside the workspace is
copied in; an in-workspace file is referenced as-is with no copy.

Consolidates the file-sync design from NousResearch#38615 (LeonSGP43) and the
host-file-staging idea from NousResearch#33455 (Carry00), rebased onto the
image/PDF remote-media helpers already on main.

Co-authored-by: LeonSGP43 <cine.dreamer.one@gmail.com>
@OutThisLife OutThisLife mentioned this pull request Jun 9, 2026
Merged
6 tasks
OutThisLife added a commit that referenced this pull request Jun 10, 2026
@OutThisLife @LeonSGP43 @teknium1
fix(desktop): stage dropped files into the remote session workspace
4906dcf 
Finder/OS drops became `@file:/Users/...` refs that only resolve when the
gateway shares the local disk, so on a remote gateway non-image files
(PDF/CSV/Markdown/...) never reached the agent. Route OS drops through the
file.attach / image.attach_bytes upload pipeline — in-app project-tree and
gutter drags stay inline workspace-relative refs — across every drop surface:
the conversation area, the composer form, the contenteditable input, and the
message-edit composer (which still reproduced the bug).

Also:
- upload dropped files eagerly when a session exists, so the card shows a
  spinner instead of stalling the send (images stay submit-time to avoid
  racing their thumbnail write);
- round the attachment card and drop the monospace detail;
- render image previews from the bytes we already hold, so a pasted/dropped
  screenshot shows its thumbnail and previews even when its only on-disk copy
  is a transient path (the data URL is not persisted to localStorage).

Supersedes #38615, #41203.

Co-authored-by: LeonSGP <154585401+LeonSGP43@users.noreply.github.com>
Co-authored-by: Teknium <127238744+teknium1@users.noreply.github.com>
wachoo pushed a commit to wachoo/hermes-agent that referenced this pull request Jun 10, 2026
@teknium1 @LeonSGP43
feat(desktop+gateway): remote-gateway file attachments via file.attach
467ca52 
@file: attachments now work when the desktop is connected to a remote
gateway. Previously a referenced file resolved to a client-disk path the
gateway couldn't see, so context_references rejected it with "path is
outside the allowed workspace" and the agent never saw the file.

Adds a file.attach RPC (sibling to the existing image.attach_bytes /
pdf.attach byte-upload pipeline): the desktop uploads the file bytes, the
gateway stages them into <workspace>/.hermes/desktop-attachments/ and
returns a workspace-relative @file: ref that resolves cleanly. Local mode
passes the path directly; a gateway-visible file outside the workspace is
copied in; an in-workspace file is referenced as-is with no copy.

Consolidates the file-sync design from NousResearch#38615 (LeonSGP43) and the
host-file-staging idea from NousResearch#33455 (Carry00), rebased onto the
image/PDF remote-media helpers already on main.

Co-authored-by: LeonSGP43 <cine.dreamer.one@gmail.com>
wachoo pushed a commit to wachoo/hermes-agent that referenced this pull request Jun 10, 2026
@OutThisLife @LeonSGP43 @teknium1
fix(desktop): stage dropped files into the remote session workspace
3e44a88 
Finder/OS drops became `@file:/Users/...` refs that only resolve when the
gateway shares the local disk, so on a remote gateway non-image files
(PDF/CSV/Markdown/...) never reached the agent. Route OS drops through the
file.attach / image.attach_bytes upload pipeline — in-app project-tree and
gutter drags stay inline workspace-relative refs — across every drop surface:
the conversation area, the composer form, the contenteditable input, and the
message-edit composer (which still reproduced the bug).

Also:
- upload dropped files eagerly when a session exists, so the card shows a
  spinner instead of stalling the send (images stay submit-time to avoid
  racing their thumbnail write);
- round the attachment card and drop the monospace detail;
- render image previews from the bytes we already hold, so a pasted/dropped
  screenshot shows its thumbnail and previews even when its only on-disk copy
  is a transient path (the data URL is not persisted to localStorage).

Supersedes NousResearch#38615, NousResearch#41203.

Co-authored-by: LeonSGP <154585401+LeonSGP43@users.noreply.github.com>
Co-authored-by: Teknium <127238744+teknium1@users.noreply.github.com>
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
@teknium1 @LeonSGP43 @changman
feat(desktop+gateway): remote-gateway file attachments via file.attach
e5cb22e 
@file: attachments now work when the desktop is connected to a remote
gateway. Previously a referenced file resolved to a client-disk path the
gateway couldn't see, so context_references rejected it with "path is
outside the allowed workspace" and the agent never saw the file.

Adds a file.attach RPC (sibling to the existing image.attach_bytes /
pdf.attach byte-upload pipeline): the desktop uploads the file bytes, the
gateway stages them into <workspace>/.hermes/desktop-attachments/ and
returns a workspace-relative @file: ref that resolves cleanly. Local mode
passes the path directly; a gateway-visible file outside the workspace is
copied in; an in-workspace file is referenced as-is with no copy.

Consolidates the file-sync design from NousResearch#38615 (LeonSGP43) and the
host-file-staging idea from NousResearch#33455 (Carry00), rebased onto the
image/PDF remote-media helpers already on main.

Co-authored-by: LeonSGP43 <cine.dreamer.one@gmail.com>
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
@OutThisLife @LeonSGP43
@teknium1 @changman
fix(desktop): stage dropped files into the remote session workspace
919336e 
Finder/OS drops became `@file:/Users/...` refs that only resolve when the
gateway shares the local disk, so on a remote gateway non-image files
(PDF/CSV/Markdown/...) never reached the agent. Route OS drops through the
file.attach / image.attach_bytes upload pipeline — in-app project-tree and
gutter drags stay inline workspace-relative refs — across every drop surface:
the conversation area, the composer form, the contenteditable input, and the
message-edit composer (which still reproduced the bug).

Also:
- upload dropped files eagerly when a session exists, so the card shows a
  spinner instead of stalling the send (images stay submit-time to avoid
  racing their thumbnail write);
- round the attachment card and drop the monospace detail;
- render image previews from the bytes we already hold, so a pasted/dropped
  screenshot shows its thumbnail and previews even when its only on-disk copy
  is a transient path (the data URL is not persisted to localStorage).

Supersedes NousResearch#38615, NousResearch#41203.

Co-authored-by: LeonSGP <154585401+LeonSGP43@users.noreply.github.com>
Co-authored-by: Teknium <127238744+teknium1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have tool/file File tools (read, write, patch, search) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Desktop drag-drop file uploads don't sync to remote gateway workspace

3 participants

@LeonSGP43 @teknium1 @alt-glitch