fix(delegate_task): send empty list instead of None for tools#3736
Closed
kelsia14 wants to merge 1 commit into
Closed
fix(delegate_task): send empty list instead of None for tools#3736kelsia14 wants to merge 1 commit into
kelsia14 wants to merge 1 commit into
Conversation
Fireworks AI (and other strict OpenAI-compatible providers) reject HTTP 400 when tools=None is sent in the API request. This happens when a subagent has no valid tools after filtering blocked ones. Changed: self.tools if self.tools else None To: self.tools if self.tools else [] Fixes subagent delegation failure with: "Input should be a valid list, field: 'tools', value: None"
Contributor
|
Fixed in #3820 with a better approach. Your PR correctly identified the issue (providers rejecting |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…usResearch#3820) Some providers (Fireworks AI) reject tools=null, and others (Anthropic) reject tools=[]. The safest approach is to not include the key at all when there are no tools — the OpenAI SDK treats a missing parameter as NOT_GIVEN and omits it from the request entirely. Inspired by PR NousResearch#3736 (@kelsia14).
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…usResearch#3820) Some providers (Fireworks AI) reject tools=null, and others (Anthropic) reject tools=[]. The safest approach is to not include the key at all when there are no tools — the OpenAI SDK treats a missing parameter as NOT_GIVEN and omits it from the request entirely. Inspired by PR NousResearch#3736 (@kelsia14).
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…usResearch#3820) Some providers (Fireworks AI) reject tools=null, and others (Anthropic) reject tools=[]. The safest approach is to not include the key at all when there are no tools — the OpenAI SDK treats a missing parameter as NOT_GIVEN and omits it from the request entirely. Inspired by PR NousResearch#3736 (@kelsia14).
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…usResearch#3820) Some providers (Fireworks AI) reject tools=null, and others (Anthropic) reject tools=[]. The safest approach is to not include the key at all when there are no tools — the OpenAI SDK treats a missing parameter as NOT_GIVEN and omits it from the request entirely. Inspired by PR NousResearch#3736 (@kelsia14).
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…usResearch#3820) Some providers (Fireworks AI) reject tools=null, and others (Anthropic) reject tools=[]. The safest approach is to not include the key at all when there are no tools — the OpenAI SDK treats a missing parameter as NOT_GIVEN and omits it from the request entirely. Inspired by PR NousResearch#3736 (@kelsia14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
delegate_taskfails with Fireworks AI (and other strict OpenAI-compatible providers) when a subagent has no valid tools after filtering blocked ones:Root Cause
In
_build_api_kwargs(), whenself.toolsis an empty list[](falsy in Python), the code was converting it toNone:Fireworks AI rejects
tools=None— it requires either a valid list or the parameter omitted entirely.Fix
Changed to always send a valid list:
Testing
Note: This is a minimal one-line fix with no breaking changes.