Skip to content

chore(attribution): map SiTaggart for PR #35583#36189

Merged
benbarclay merged 1 commit into
mainfrom
chore/attribution-sitaggart-35583
Jun 1, 2026
Merged

chore(attribution): map SiTaggart for PR #35583#36189
benbarclay merged 1 commit into
mainfrom
chore/attribution-sitaggart-35583

Conversation

@benbarclay

Copy link
Copy Markdown
Collaborator

Adds me@simontaggart.comSiTaggart to AUTHOR_MAP in scripts/release.py.

The check-attribution CI gate fails on #35583 because Simon Taggart's commit email isn't mapped yet. This backfills the mapping so #35583 (the docker_forward_env empty-secret .env fallback fix, closes #35580) can pass attribution and merge cleanly.

Pure data addition — no logic change.

Adds me@simontaggart.com → SiTaggart to AUTHOR_MAP so the
check-attribution gate passes for the docker_forward_env empty-secret
fix (#35583, fixes #35580).
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: chore/attribution-sitaggart-35583 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9556 on HEAD, 9556 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4954 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have labels Jun 1, 2026
@benbarclay benbarclay merged commit e2ee917 into main Jun 1, 2026
22 checks passed
@benbarclay benbarclay deleted the chore/attribution-sitaggart-35583 branch June 1, 2026 02:16
JoeKowal pushed a commit to JoeKowal/hermes-agent that referenced this pull request Jun 4, 2026
…arch#36189)

Adds me@simontaggart.com → SiTaggart to AUTHOR_MAP so the
check-attribution gate passes for the docker_forward_env empty-secret
fix (NousResearch#35583, fixes NousResearch#35580).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: docker_forward_env forwards empty-string secrets into sandbox, bypassing the ~/.hermes/.env disk fallback

2 participants