fix(install): build desktop in 'desktop' stage on macOS/Linux instead of silently skipping#36134
Merged
Conversation
… of silently skipping
The thin installer (apps/bootstrap-installer) drives install.sh stage-by-stage,
each in its own process. The `desktop` stage never called check_node, so the
Hermes-managed Node provisioned earlier (at $HERMES_HOME/node/bin) wasn't on
PATH. install_desktop's `command -v npm` check then failed and the build was
skipped — yet the stage still reported {"ok":true,"skipped":false}, so the
installer showed "Installation Complete" and only failed at the end with
"Couldn't find a built Hermes desktop ... the desktop build step may have been
skipped or failed."
Fix:
- Call check_node in the `desktop` stage (mirrors every other Node-dependent
stage) so the managed Node is on PATH (or installed).
- Make install_desktop self-provision via check_node and hard-fail (return 1)
if npm is still unavailable, instead of a silent `return 0`. The desktop
stage only runs when a build is explicitly requested (--include-desktop), so
an unavailable toolchain is a real failure, not graceful degradation.
Verified on macOS arm64: the `desktop` stage now builds
release/mac-arm64/Hermes.app, which matches resolve_hermes_desktop_exe, so the
installer's "Launch Hermes" succeeds.
Contributor
🔎 Lint report:
|
mxnstrexgl
approved these changes
Jun 1, 2026
mxnstrexgl
left a comment
There was a problem hiding this comment.
LGTM — automated review passed. No security, quality, or test coverage issues detected.
JoeKowal
pushed a commit
to JoeKowal/hermes-agent
that referenced
this pull request
Jun 4, 2026
… of silently skipping (NousResearch#36134) The thin installer (apps/bootstrap-installer) drives install.sh stage-by-stage, each in its own process. The `desktop` stage never called check_node, so the Hermes-managed Node provisioned earlier (at $HERMES_HOME/node/bin) wasn't on PATH. install_desktop's `command -v npm` check then failed and the build was skipped — yet the stage still reported {"ok":true,"skipped":false}, so the installer showed "Installation Complete" and only failed at the end with "Couldn't find a built Hermes desktop ... the desktop build step may have been skipped or failed." Fix: - Call check_node in the `desktop` stage (mirrors every other Node-dependent stage) so the managed Node is on PATH (or installed). - Make install_desktop self-provision via check_node and hard-fail (return 1) if npm is still unavailable, instead of a silent `return 0`. The desktop stage only runs when a build is explicitly requested (--include-desktop), so an unavailable toolchain is a real failure, not graceful degradation. Verified on macOS arm64: the `desktop` stage now builds release/mac-arm64/Hermes.app, which matches resolve_hermes_desktop_exe, so the installer's "Launch Hermes" succeeds.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the macOS (and Linux) thin installer path work end-to-end. The Tauri "Hermes Setup" installer (
apps/bootstrap-installer) drivesscripts/install.shstage-by-stage, each stage in its own process. Thedesktopstage never calledcheck_node, so the Hermes-managed Node provisioned during earlier stages ($HERMES_HOME/node/bin) wasn't onPATH.install_desktop'scommand -v npmcheck then failed and the build was silently skipped — while still reporting{"ok":true,"skipped":false}.Result for the user: the installer showed "Installation Complete", then "Launch Hermes" failed with "Couldn't find a built Hermes desktop … the desktop build step may have been skipped or failed."
Changes
desktopstage now callscheck_node(mirrors every other Node-dependent stage) so the managed Node is onPATH(or gets installed).install_desktopself-provisions viacheck_nodeand hard-fails (return 1) if npm is still unavailable, instead of a silentreturn 0. The desktop stage only runs when a build is explicitly requested (--include-desktop/desktopstage), so a missing toolchain is a genuine failure, not graceful degradation — failing loudly prevents the confusing "complete but no app" state.Test plan
⚠ Skipping desktop build (Node.js / npm not on PATH)and "Launch Hermes" failed.desktopstage with the managed Node only (no system Node) → buildsapps/desktop/release/mac-arm64/Hermes.app, which matchesresolve_hermes_desktop_exe, so "Launch Hermes" succeeds.bash -n scripts/install.shpasses.Notes
APPLE_*signing env vars automatically at build time when we're ready, so no config change is needed here.