Revert "fix(tui): clamp bogus terminal dimensions (WSL 131072x1)" (#35657)#36096
Merged
Conversation
)" This reverts commit b1d34cf.
Contributor
🔎 Lint report:
|
mxnstrexgl
approved these changes
Jun 1, 2026
mxnstrexgl
left a comment
There was a problem hiding this comment.
LGTM — automated review passed. No security, quality, or test coverage issues detected.
This was referenced Jun 3, 2026
JoeKowal
pushed a commit
to JoeKowal/hermes-agent
that referenced
this pull request
Jun 4, 2026
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #35657 (
b1d34cf6) — the WSL dimension clamp broke live terminal resize.Root cause: the fix redefined
process.stdout.columns/rowsas getter-only accessors. Node'stty.WriteStreamresize path writes to those properties onSIGWINCH(_refreshSizeassigns the new size); a getter-only descriptor blocks that write, so the stream can no longer update its own dimensions and the Ink renderer keeps reading stale/clamped values on resize.Changes
ui-tui/src/entry.tsx,ui-tui/src/lib/terminalDimensions.ts, and its test (258 deletions).recordParentLifecycleimport added to entry.tsx after fix(tui): clamp bogus terminal dimensions (WSL 131072x1) #35657 merged.Validation
tsc --noEmiton the worktree: 18 errors, all pre-existing inpackages/hermes-ink/src/utils/execFileNoThrow.ts— identical count on cleanmain. Zero new errors from the revert; none inentry.tsx.The original WSL
131072x1bogus-dimension problem still needs a fix that clamps without breaking resize (e.g. clamp at the layout/read sites, not by freezing the stream descriptor) — leaving #35657's issue open for a follow-up.Infographic